From: Marcelo Tosatti <marcelo.tosatti@cyclades.com>
To: torvalds@osdl.org, linux-kernel@vger.kernel.org
Cc: akpm@osdl.org
Subject: [PATCH] Enable gcc warnings for vsprintf/vsnprintf with "format" attribute
Date: Sun, 13 Mar 2005 11:06:06 -0300 [thread overview]
Message-ID: <20050313140606.GA5946@logos.cnet> (raw)
Applied to v2.4 - v2.6 wants the same change.
Against v2.6-BK.
From: Solar Designer <solar@openwall.com>
Enables gcc warnings for the case when arguments to vsprintf/vsnprintf
function don't match the format string. This helps catch programming
errors.
--- a/include/linux/kernel.h.orig 2005-03-13 14:42:52.069920616 -0300
+++ b/include/linux/kernel.h 2005-03-13 14:45:15.192162728 -0300
@@ -91,10 +91,12 @@
extern long long simple_strtoll(const char *,char **,unsigned int);
extern int sprintf(char * buf, const char * fmt, ...)
__attribute__ ((format (printf, 2, 3)));
-extern int vsprintf(char *buf, const char *, va_list);
+extern int vsprintf(char *buf, const char *, va_list)
+ __attribute__ ((format (printf, 2, 0)));
extern int snprintf(char * buf, size_t size, const char * fmt, ...)
__attribute__ ((format (printf, 3, 4)));
-extern int vsnprintf(char *buf, size_t size, const char *fmt, va_list args);
+extern int vsnprintf(char *buf, size_t size, const char *fmt, va_list args)
+ __attribute__ ((format (printf, 3, 0)));
extern int scnprintf(char * buf, size_t size, const char * fmt, ...)
__attribute__ ((format (printf, 3, 4)));
extern int vscnprintf(char *buf, size_t size, const char *fmt, va_list args);
reply other threads:[~2005-03-14 1:19 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050313140606.GA5946@logos.cnet \
--to=marcelo.tosatti@cyclades.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox