Re: [patch 01/14] char/snsc: reorder set_current_state() and add_wait_queue()

[Jesse Barnes <jbarnes@engr.sgi.com>]

[-- Attachment #1: Type: text/plain, Size: 973 bytes --]

On Monday, March 14, 2005 9:54 am, Nishanth Aravamudan wrote:
> On Mon, Mar 14, 2005 at 09:45:44AM -0800, Jesse Barnes wrote:
> > On Sunday, March 6, 2005 2:36 pm, domen@coderock.org wrote:
> > > Any comments would be, as always, appreciated.
> >
> > I don't have a problem with this change, but the maintainer probably
> > should have been Cc'd.  Greg, does this change look ok to you?  Note that
> > it's already been committed to the upstream tree, so if it's a bad change
> > we'll need to have the cset excluded or something.
>
> Thanks for the feedback. I don't see a maintainer entry for Greg
> anywhere in the snsc.{c,h} files or MAINTAINERS. Could someone throw a
> patch upstream so that whomever should be contacted for this driver will
> be in the future?

Good point :)  I assumed there was a MODULE_AUTHOR entry.  Here's a patch to 
get Greg more spam^W^W^W^Wadd the relevant info.  Look ok to you Greg?

Signed-off-by: Jesse Barnes <jbarnes@sgi.com>

Jesse


[-- Attachment #2: snsc-author.patch --]
[-- Type: text/plain, Size: 416 bytes --]

===== drivers/char/snsc.c 1.4 vs edited =====
--- 1.4/drivers/char/snsc.c	2005-03-13 15:30:07 -08:00
+++ edited/drivers/char/snsc.c	2005-03-14 10:01:38 -08:00
@@ -28,6 +28,10 @@
 #include <asm/sn/nodepda.h>
 #include "snsc.h"
 
+MODULE_AUTHOR("Greg Howard <ghoward@sgi.com>");
+MODULE_DESCRIPTION("SGI System Controller driver");
+MODULE_LICENSE("GPL");
+
 #define SYSCTL_BASENAME	"snsc"
 
 #define SCDRV_BUFSZ	2048