Re: [PATCH]: Fix compiler warning in drivers/scsi/dpt_i2o.c

[Stefan Roas <sroas@roath.org>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Mon Mar 14, 2005 at 18:24:44, Ben Dooks wrote:

> This patch looks suspiciously like it is sweeping the problem
> `under the carpet`. Does bus_to_virt() return an `void __iomem *`?
> 
> reply should really be an `void __iomem *` 

bus_to_virt returns void *.

adpt_isr casts the return value to ulong though and adpt_i2o_to_scsi
takes an ulong as its first argument and passes it to readl without a
cast then.

But I agree, the patch just silences the compiler warning. Maybe it
would be a better solution to change the types of reply and msg in
adpt_isr as well as the first argument to adpt_i2o_to_scsi to void
__iomem *.


Best Regards,

- -- 
Stefan Roas
sroas@roath.org
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (GNU/Linux)

iD8DBQFCNe7CwvfNuQ9pAq8RAmDBAJ0XyRMogsfgX3L6+SzIzp6VPYuynQCgjpZ0
94sI0Fr7V8anGTsQQw+COcM=
=+qfk
-----END PGP SIGNATURE-----