From: Andrew Morton <akpm@osdl.org>
To: Bernhard Rosenkraenzer <bero@arklinux.org>
Cc: linux-kernel@vger.kernel.org, Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: 2.6.11-mm3 breaks compile of drivers/char/esp.c
Date: Mon, 14 Mar 2005 20:33:57 -0800 [thread overview]
Message-ID: <20050314203357.75aacaaf.akpm@osdl.org> (raw)
In-Reply-To: <200503121839.36970.bero@arklinux.org>
Bernhard Rosenkraenzer <bero@arklinux.org> wrote:
>
> drivers/char/esp.c: In function 'rs_stop':
> drivers/char/esp.c:213: error: 'struct esp_struct' has no member named 'lock'
> drivers/char/esp.c:219: error: 'struct esp_struct' has no member named 'lock'
> drivers/char/esp.c: In function 'rs_start':
> drivers/char/esp.c:230: error: 'struct esp_struct' has no member named 'lock'
> drivers/char/esp.c:236: error: 'struct esp_struct' has no member named 'lock'
Seems that Alan's diff was missing the changes to the header file. Like
this?
--- 25/include/linux/hayesesp.h~esp-build-fix 2005-03-14 20:31:18.000000000 -0800
+++ 25-akpm/include/linux/hayesesp.h 2005-03-14 20:31:30.000000000 -0800
@@ -77,6 +77,7 @@ struct hayes_esp_config {
struct esp_struct {
int magic;
+ spinlock_t lock;
int port;
int irq;
int flags; /* defined in tty.h */
_
I didn't pick this up because ESPSERIAL is still BROKEN_ON_SMP. Alan,
should we remove that now?
next prev parent reply other threads:[~2005-03-15 4:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-12 17:39 2.6.11-mm3 breaks compile of drivers/char/esp.c Bernhard Rosenkraenzer
2005-03-15 4:33 ` Andrew Morton [this message]
2005-03-15 13:38 ` Alan Cox
2005-03-18 1:50 ` 2.6.11-mm3 - redzone mismatch Andrew James Wade
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050314203357.75aacaaf.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=bero@arklinux.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox