From: "David S. Miller" <davem@davemloft.net>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: rmk+lkml@arm.linux.org.uk, linux-kernel@vger.kernel.org,
netfilter@lists.netfilter.org
Subject: Re: Netfilter ipt_hashlimit
Date: Mon, 14 Mar 2005 21:41:38 -0800 [thread overview]
Message-ID: <20050314214138.025b2e43.davem@davemloft.net> (raw)
In-Reply-To: <E1D9itD-00039G-00@gondolin.me.apana.org.au>
On Fri, 11 Mar 2005 23:05:11 +1100
Herbert Xu <herbert@gondor.apana.org.au> wrote:
> Russell King <rmk+lkml@arm.linux.org.uk> wrote:
> > With current-ish Linus 2.6 BK, I'm seeing this:
> >
> > net/ipv4/netfilter/ipt_hashlimit.c:96: warning: type defaults to `int' in declaration of `DECLARE_LOCK'
> > net/ipv4/netfilter/ipt_hashlimit.c:96: warning: parameter names (without types) in function declaration
> >
> > Looks like ipt_hashlimit.c is missing an include?
>
> Indeed. It should include lockhelp.h directly.
>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Applied, thanks Herbert.
prev parent reply other threads:[~2005-03-15 5:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-10 22:29 Netfilter ipt_hashlimit Russell King
2005-03-11 12:05 ` Herbert Xu
2005-03-15 5:41 ` David S. Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050314214138.025b2e43.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=netfilter@lists.netfilter.org \
--cc=rmk+lkml@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox