From: Greg KH <greg@kroah.com>
To: Phillip Lougher <phillip@lougher.demon.co.uk>
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][2/2] SquashFS
Date: Mon, 14 Mar 2005 21:38:27 -0800 [thread overview]
Message-ID: <20050315053827.GA13337@kroah.com> (raw)
In-Reply-To: <4235BC29.2060009@lougher.demon.co.uk>
On Mon, Mar 14, 2005 at 04:30:33PM +0000, Phillip Lougher wrote:
> +typedef unsigned int squashfs_block;
> +typedef long long squashfs_inode;
Try using u32 and u64 instead.
> +typedef unsigned int squashfs_uid;
Why is this a typedef?
> +
> +typedef struct squashfs_super_block {
Don't typedef structures, it's not the kernel way.
thanks,
greg k-h
prev parent reply other threads:[~2005-03-15 5:38 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-14 16:30 [PATCH][2/2] SquashFS Phillip Lougher
2005-03-15 1:06 ` Andrew Morton
2005-03-15 1:14 ` Phillip Lougher
2005-03-15 3:01 ` Andrew Morton
2005-03-15 17:16 ` Phillip Lougher
2005-03-15 18:21 ` Paulo Marques
2005-03-21 10:14 ` Pavel Machek
2005-03-21 15:56 ` Phillip Lougher
2005-03-21 19:00 ` Pavel Machek
2005-03-21 18:03 ` Phillip Lougher
2005-03-21 22:49 ` Pavel Machek
2005-03-22 2:41 ` Josh Boyer
2005-03-22 2:58 ` David Lang
2005-03-22 3:04 ` Andrew Morton
2005-03-22 2:59 ` Phillip Lougher
2005-03-22 5:32 ` Paul Jackson
2005-03-22 3:34 ` Phillip Lougher
2005-03-22 5:37 ` Stefan Smietanowski
2005-03-21 22:32 ` Mws
2005-03-21 22:44 ` Pavel Machek
2005-03-21 22:54 ` Mws
2005-03-22 3:36 ` Phillip Lougher
2005-03-22 7:19 ` Stefan Smietanowski
2005-03-22 5:20 ` Willy Tarreau
2005-03-21 18:08 ` Mws
2005-03-21 18:54 ` Pavel Machek
2005-03-21 22:23 ` Mws
2005-03-21 22:31 ` Pavel Machek
2005-03-21 22:47 ` Mws
2005-03-21 22:56 ` Pavel Machek
2005-03-15 3:12 ` Matt Mackall
2005-03-15 23:25 ` Phillip Lougher
2005-03-16 0:57 ` Andrew Morton
2005-03-16 1:04 ` Matt Mackall
2005-03-16 4:19 ` Matt Mackall
2005-03-15 5:38 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050315053827.GA13337@kroah.com \
--to=greg@kroah.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=phillip@lougher.demon.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox