public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@stusta.de>
To: Mikael Pettersson <mikpe@user.it.uu.se>
Cc: linux-kernel@vger.kernel.org, R.E.Wolff@BitWizard.nl
Subject: Re: [PATCH][2.6.11] generic_serial.h gcc4 fix
Date: Tue, 15 Mar 2005 18:39:46 +0100	[thread overview]
Message-ID: <20050315173946.GR3189@stusta.de> (raw)
In-Reply-To: <16951.6077.612190.675720@alkaid.it.uu.se>

On Tue, Mar 15, 2005 at 06:13:33PM +0100, Mikael Pettersson wrote:
> Fix
> 
> drivers/char/generic_serial.c:38: error: static declaration of 'gs_debug' follows non-static declaration
> include/linux/generic_serial.h:94: error: previous declaration of 'gs_debug' was here
> 
> compilation error from gcc4 in generic_serial.h.
> 
> /Mikael
> 
> --- linux-2.6.11/include/linux/generic_serial.h.~1~	2005-03-02 19:24:19.000000000 +0100
> +++ linux-2.6.11/include/linux/generic_serial.h	2005-03-15 17:11:07.000000000 +0100
> @@ -91,6 +91,4 @@ int  gs_setserial(struct gs_port *port, 
>  int  gs_getserial(struct gs_port *port, struct serial_struct __user *sp);
>  void gs_got_break(struct gs_port *port);
>  
> -extern int gs_debug;
> -
>  #endif

This patch is already in -mm for ages.

When doing such patches, -mm is usually a better basis than Linus' tree.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


  reply	other threads:[~2005-03-15 17:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-03-15 17:13 [PATCH][2.6.11] generic_serial.h gcc4 fix Mikael Pettersson
2005-03-15 17:39 ` Adrian Bunk [this message]
2005-03-16  6:32   ` Rogier Wolff

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050315173946.GR3189@stusta.de \
    --to=bunk@stusta.de \
    --cc=R.E.Wolff@BitWizard.nl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mikpe@user.it.uu.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox