From: Chris Wright <chrisw@osdl.org>
To: linux-kernel@vger.kernel.org, stable@kernel.org
Cc: dilinger@debian.org, jgarzik@pobox.com, torvalds@osdl.org,
akpm@osdl.org, alan@lxorguk.ukuu.org.uk, jmforbes@linuxtx.org,
zwane@arm.linux.org.uk, cliffw@osdl.org, tytso@mit.edu,
rddunlap@osdl.org
Subject: [2/9] Possible AMD8111e free irq issue
Date: Wed, 16 Mar 2005 15:54:27 -0800 [thread overview]
Message-ID: <20050316235427.GA5389@shell0.pdx.osdl.net> (raw)
In-Reply-To: <20050316235336.GY5389@shell0.pdx.osdl.net>
-stable review patch. If anyone has any objections, please let us know.
----
From: Andres Salomon <dilinger@debian.org>
It seems to me that if in the amd8111e_open() fuction dev->irq isn't
zero and the irq request succeeds it might not get released anymore.
Specifically, on failure of the amd8111e_restart() call the function
returns -ENOMEM without releasing the irq. The amd8111e_restart()
function can fail because of various pci_alloc_consistent() and
dev_alloc_skb() calls in amd8111e_init_ring() which is being
called by amd8111e_restart.
1374 if(dev->irq ==0 || request_irq(dev->irq, amd8111e_interrupt, SA_SHIRQ,
1375 dev->name, dev))
1376 return -EAGAIN;
Signed-off-by: Jeff Garzik <jgarzik@pobox.com>
Signed-off-by: Chris Wright <chrisw@osdl.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
diff -Naru a/drivers/net/amd8111e.c b/drivers/net/amd8111e.c
--- a/drivers/net/amd8111e.c 2005-03-09 20:29:47 -08:00
+++ b/drivers/net/amd8111e.c 2005-03-09 20:29:47 -08:00
@@ -1381,6 +1381,8 @@
if(amd8111e_restart(dev)){
spin_unlock_irq(&lp->lock);
+ if (dev->irq)
+ free_irq(dev->irq, dev);
return -ENOMEM;
}
/* Start ipg timer */
next prev parent reply other threads:[~2005-03-16 23:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-16 23:53 [0/9] -stable review Chris Wright
2005-03-16 23:54 ` [1/9] [ALSA] Fix stereo mutes on Surround volume control Chris Wright
2005-03-16 23:54 ` Chris Wright [this message]
2005-03-17 0:19 ` [2/9] Possible AMD8111e free irq issue Ian Pilcher
2005-03-17 1:03 ` Chris Wright
2005-03-17 1:13 ` Ian Pilcher
2005-03-17 2:00 ` Jeff Garzik
2005-03-16 23:54 ` [3/9] [IPSEC]: Fix __xfrm_find_acq_byseq() Chris Wright
2005-03-16 23:54 ` [4/9] NetROM locking Chris Wright
2005-03-16 23:55 ` [5/9] [TUN] Fix check for underflow Chris Wright
2005-03-17 0:13 ` Patrick McHardy
2005-03-17 0:23 ` Chris Wright
2005-03-16 23:55 ` [6/9] tasklist left locked Chris Wright
2005-03-16 23:55 ` [7/9] Timercode race in AX.25 Chris Wright
2005-03-16 23:55 ` [8/9] Possible VIA-Rhine free irq issue Chris Wright
2005-03-16 23:55 ` [9/9] Fix kernel panic on receive with WAN Hitachi SCA HD6457x Chris Wright
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050316235427.GA5389@shell0.pdx.osdl.net \
--to=chrisw@osdl.org \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=cliffw@osdl.org \
--cc=dilinger@debian.org \
--cc=jgarzik@pobox.com \
--cc=jmforbes@linuxtx.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rddunlap@osdl.org \
--cc=stable@kernel.org \
--cc=torvalds@osdl.org \
--cc=tytso@mit.edu \
--cc=zwane@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox