From: Chris Wright <chrisw@osdl.org>
To: Ian Pilcher <i.pilcher@comcast.net>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [2/9] Possible AMD8111e free irq issue
Date: Wed, 16 Mar 2005 17:03:59 -0800 [thread overview]
Message-ID: <20050317010359.GD28536@shell0.pdx.osdl.net> (raw)
In-Reply-To: <d1aicj$iq1$2@sea.gmane.org>
* Ian Pilcher (i.pilcher@comcast.net) wrote:
> Chris Wright wrote:
> >
> >From: Andres Salomon <dilinger@debian.org>
> >
> >It seems to me that if in the amd8111e_open() fuction dev->irq isn't
> >zero and the irq request succeeds it might not get released anymore.
>
> Based on the wording above, I can't help wondering if this fixes a
> problem that anyone is actually seeing.
I had same hesitation, but it's easy to see how lowmem could trigger
this latent bug (so it's not a highly theoretical race condition, for
example), and the fix is both quite simple and accepted upstream already.
Anyway that's what the review cycle is for, it can be rejected.
thanks,
-chris
--
Linux Security Modules http://lsm.immunix.org http://lsm.bkbits.net
next prev parent reply other threads:[~2005-03-17 1:04 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-16 23:53 [0/9] -stable review Chris Wright
2005-03-16 23:54 ` [1/9] [ALSA] Fix stereo mutes on Surround volume control Chris Wright
2005-03-16 23:54 ` [2/9] Possible AMD8111e free irq issue Chris Wright
2005-03-17 0:19 ` Ian Pilcher
2005-03-17 1:03 ` Chris Wright [this message]
2005-03-17 1:13 ` Ian Pilcher
2005-03-17 2:00 ` Jeff Garzik
2005-03-16 23:54 ` [3/9] [IPSEC]: Fix __xfrm_find_acq_byseq() Chris Wright
2005-03-16 23:54 ` [4/9] NetROM locking Chris Wright
2005-03-16 23:55 ` [5/9] [TUN] Fix check for underflow Chris Wright
2005-03-17 0:13 ` Patrick McHardy
2005-03-17 0:23 ` Chris Wright
2005-03-16 23:55 ` [6/9] tasklist left locked Chris Wright
2005-03-16 23:55 ` [7/9] Timercode race in AX.25 Chris Wright
2005-03-16 23:55 ` [8/9] Possible VIA-Rhine free irq issue Chris Wright
2005-03-16 23:55 ` [9/9] Fix kernel panic on receive with WAN Hitachi SCA HD6457x Chris Wright
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050317010359.GD28536@shell0.pdx.osdl.net \
--to=chrisw@osdl.org \
--cc=i.pilcher@comcast.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox