From: "Theodore Ts'o" <tytso@mit.edu>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Andrew Morton <akpm@osdl.org>,
Linux Kernel list <linux-kernel@vger.kernel.org>,
linux-thinkpad@linux-thinkpad.org, "Brown,
Len" <len.brown@intel.com>,
Volker Braun <volker.braun@physik.hu-berlin.de>
Subject: Re: [PATCH 2/2] Thinkpad Suspend Powersave: Add D2 power saving code for Thinkpads with Radeon video chipsets
Date: Thu, 17 Mar 2005 22:39:28 -0500 [thread overview]
Message-ID: <20050318033928.GD4851@thunk.org> (raw)
In-Reply-To: <1111015144.15510.47.camel@gaston>
On Thu, Mar 17, 2005 at 10:19:04AM +1100, Benjamin Herrenschmidt wrote:
> You probably want to remove the bit that does
>
> OUTREG(TV_DAC_CNTL, INREG(TV_DAC_CNTL) | 0x07000000);
>
> Or you'll lose TV output :)
I'm not using TV output, and the original patch stated:
> > + /* Power down TV DAC, that saves a significant amount of power,
> > + * we'll have something better once we actually have some TVOut
> > + * support
> > + */
I suppose I should renable the TV DAC and see how much power it
actually consumes if I enable it. It would seem to me that we should
have a way that we can power down whatever parts of the video chipset
that we're not using. (For example if I don't have anything connected
to the VGA output, it would be good if we could power that down too...)
- Ted
next prev parent reply other threads:[~2005-03-18 3:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <3.518178082@mit.edu>
2005-03-16 23:19 ` [PATCH 2/2] Thinkpad Suspend Powersave: Add D2 power saving code for Thinkpads with Radeon video chipsets Benjamin Herrenschmidt
2005-03-18 3:39 ` Theodore Ts'o [this message]
2005-03-18 4:41 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050318033928.GD4851@thunk.org \
--to=tytso@mit.edu \
--cc=akpm@osdl.org \
--cc=benh@kernel.crashing.org \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-thinkpad@linux-thinkpad.org \
--cc=volker.braun@physik.hu-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox