From: Sam Ravnborg <sam@ravnborg.org>
To: Nicolas Kaiser <nikai@nikai.net>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org, domen@coderock.org
Subject: Re: [patch 12/12] scripts/mod/sumversion.c: replace strtok() with strsep()
Date: Fri, 18 Mar 2005 06:33:01 +0100 [thread overview]
Message-ID: <20050318053301.GA32433@mars.ravnborg.org> (raw)
In-Reply-To: <20050318034620.0a8ac96d@lucky.kitzblitz>
On Fri, Mar 18, 2005 at 03:46:20AM +0100, Nicolas Kaiser wrote:
> * Sam Ravnborg <sam@ravnborg.org>:
>
> > On Sat, Mar 05, 2005 at 04:35:45PM +0100, domen@coderock.org wrote:
> > >
> > > Replaces strtok() with strsep()
> >
> > Why - does it increase portability?
>
> "strtok() is not thread and SMP safe and strsep() should be
> used instead"
>
> http://janitor.kernelnewbies.org/docs/driver-howto.html#3.3.1
It does not matter in this particular file.
But applied for consistency (so it does not show up if you grep for it).
Sam
prev parent reply other threads:[~2005-03-18 5:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-05 15:35 [patch 12/12] scripts/mod/sumversion.c: replace strtok() with strsep() domen
2005-03-17 21:23 ` Sam Ravnborg
2005-03-18 2:46 ` Nicolas Kaiser
2005-03-18 5:33 ` Sam Ravnborg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050318053301.GA32433@mars.ravnborg.org \
--to=sam@ravnborg.org \
--cc=akpm@osdl.org \
--cc=domen@coderock.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nikai@nikai.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox