From: Greg KH <gregkh@suse.de>
To: Pavel Machek <pavel@ucw.cz>
Cc: Andrew Morton <akpm@osdl.org>,
kernel list <linux-kernel@vger.kernel.org>
Subject: Re: fix-u32-vs-pm_message_t-in-usb
Date: Fri, 18 Mar 2005 13:43:36 -0800 [thread overview]
Message-ID: <20050318214335.GA17813@kroah.com> (raw)
In-Reply-To: <20050311130831.GC1379@elf.ucw.cz>
On Fri, Mar 11, 2005 at 02:08:31PM +0100, Pavel Machek wrote:
> Hi!
>
> > This patch has been spitting warnings:
> >
> > drivers/usb/host/uhci-hcd.c:838: warning: initialization from incompatible pointer type
> > drivers/usb/host/ohci-pci.c:191: warning: initialization from incompatible pointer type
> >
> > Because hc_driver.suspend() takes a u32 as its second arg. Changing that
> > to pci_power_t causes build failures and including pci.h in usb.h seems
> > wrong.
> >
> > Wanna fix it sometime?
>
> Yep. Here it is.
>
> This fixes remaining confusion. Part of my old patch was merged, I
> later decided passing pci_power_t down to drivers is bad idea; this
> passes them pm_message_t which contains more info (and actually works
> :-). Please apply,
Argh, this one is already partially in, and another one you just sent me
has half of it in the tree too...
Care to just rediff off of 2.6.12-rc1? Then we can hopefully get these
changes in :)
thanks,
greg k-h
next prev parent reply other threads:[~2005-03-18 22:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20050310223353.47601d54.akpm@osdl.org>
2005-03-11 13:08 ` fix-u32-vs-pm_message_t-in-usb Pavel Machek
2005-03-18 21:43 ` Greg KH [this message]
2005-03-18 23:44 ` fix-u32-vs-pm_message_t-in-usb Pavel Machek
2005-03-18 23:53 ` fix-u32-vs-pm_message_t-in-usb Andrew Morton
2005-03-19 0:00 ` fix-u32-vs-pm_message_t-in-usb Pavel Machek
2005-03-19 0:28 ` fix-u32-vs-pm_message_t-in-usb Pavel Machek
2005-03-11 13:10 ` fix-u32-vs-pm_message_t-in-usb Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050318214335.GA17813@kroah.com \
--to=gregkh@suse.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox