From: Rolf Eike Beer <eike-kernel@sf-tec.de>
To: Greg K-H <greg@kroah.com>
Cc: linux-kernel@vger.kernel.org, linux-pci@atrey.karlin.mff.cuni.cz
Subject: Re: PCI: remove pci_find_device usage from pci sysfs code.
Date: Sun, 20 Mar 2005 15:53:58 +0100 [thread overview]
Message-ID: <200503201554.05010.eike-kernel@sf-tec.de> (raw)
In-Reply-To: <11099696382576@kroah.com>
[-- Attachment #1: Type: text/plain, Size: 685 bytes --]
Greg KH wrote:
> ChangeSet 1.1998.11.23, 2005/02/25 08:26:11-08:00, gregkh@suse.de
>
> PCI: remove pci_find_device usage from pci sysfs code.
> diff -Nru a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c
> --- a/drivers/pci/pci-sysfs.c 2005-03-04 12:41:33 -08:00
> +++ b/drivers/pci/pci-sysfs.c 2005-03-04 12:41:33 -08:00
> @@ -481,7 +481,7 @@
> struct pci_dev *pdev = NULL;
>
> sysfs_initialized = 1;
> - while ((pdev = pci_find_device(PCI_ANY_ID, PCI_ANY_ID, pdev)) != NULL)
> + while ((pdev = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, pdev)) != NULL)
> pci_create_sysfs_dev_files(pdev);
>
> return 0;
Any reasons why you are not using "for_each_pci_dev(pdev)" here?
Eike
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2005-03-20 19:47 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <11099696382684@kroah.com>
2005-03-04 20:53 ` PCI: remove pci_find_device usage from pci sysfs code Greg KH
2005-03-04 20:53 ` [PATCH] PCI: Apple PCI IDs update Greg KH
2005-03-04 20:53 ` [PATCH] PCI: tone down pci=routeirq message Greg KH
2005-03-04 20:53 ` [PATCH] PCI: fix hotplug double free Greg KH
2005-03-04 20:53 ` [PATCH] PCI: One more Asus SMBus quirk Greg KH
2005-03-08 22:18 ` Bill Davidsen
2005-03-08 22:21 ` Jean Delvare
2005-03-08 22:21 ` Bill Davidsen
2005-03-08 23:37 ` Greg KH
2005-03-09 16:06 ` Bill Davidsen
2005-03-09 16:37 ` Greg KH
2005-03-10 11:54 ` Bill Davidsen
2005-03-10 16:36 ` Greg KH
2005-03-20 14:53 ` Rolf Eike Beer [this message]
2005-03-21 18:40 ` PCI: remove pci_find_device usage from pci sysfs code Greg KH
2005-03-24 21:06 ` Rolf Eike Beer
2005-03-28 23:21 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200503201554.05010.eike-kernel@sf-tec.de \
--to=eike-kernel@sf-tec.de \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox