From: Nathan Lynch <ntl@pobox.com>
To: Mikael Pettersson <mikpe@csd.uu.se>
Cc: akpm@osdl.org, paulus@samba.org, linux-kernel@vger.kernel.org,
linuxppc64-dev@ozlabs.org
Subject: Re: [PATCH][2.6.12-rc1-mm1] fix compile error in ppc64 prom.c
Date: Mon, 21 Mar 2005 10:45:17 -0600 [thread overview]
Message-ID: <20050321164517.GB16469@otto> (raw)
In-Reply-To: <200503211519.j2LFJ1os021884@harpo.it.uu.se>
On Mon, Mar 21, 2005 at 04:19:01PM +0100, Mikael Pettersson wrote:
> Compiling 2.6.12-rc1-mm1 for ppc64 fails with:
>
> arch/ppc64/kernel/prom.c:1691: error: syntax error before 'prom_reconfig_notifier'
> arch/ppc64/kernel/prom.c:1692: error: field name not in record or union initializer
> arch/ppc64/kernel/prom.c:1692: error: (near initialization for 'prom_reconfig_nb')
> arch/ppc64/kernel/prom.c:1692: warning: initialization makes pointer from integer without a cast
> make[1]: *** [arch/ppc64/kernel/prom.o] Error 1
> make: *** [arch/ppc64/kernel] Error 2
>
> Fix: repair the obvious syntax error (missing "=").
Thanks for the fix; the mistake was mine. Lest Andrew and Paulus
think I'm sending untested patches, the compiler I'm using (gcc
3.3.3-hammer) does not give an error or even a warning. Sorry for the
inconvenience; I'll have to upgrade to a less forgiving version of
gcc.
Nathan
next prev parent reply other threads:[~2005-03-21 16:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-21 15:19 [PATCH][2.6.12-rc1-mm1] fix compile error in ppc64 prom.c Mikael Pettersson
2005-03-21 16:45 ` Nathan Lynch [this message]
2005-03-21 21:55 ` Paul Mackerras
2005-03-21 22:56 ` Nathan Lynch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050321164517.GB16469@otto \
--to=ntl@pobox.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc64-dev@ozlabs.org \
--cc=mikpe@csd.uu.se \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox