From: Anton Blanchard <anton@samba.org>
To: akpm@osdl.org, Mikael Pettersson <mikpe@csd.uu.se>
Cc: paulus@samba.org, linux-kernel@vger.kernel.org,
linuxppc64-dev@ozlabs.org
Subject: [PATCH] ppc64: fix gcc4 compile error in paca.h
Date: Tue, 22 Mar 2005 04:48:23 +1100 [thread overview]
Message-ID: <20050321174823.GC23908@krispykreme> (raw)
In-Reply-To: <200503211518.j2LFIMP6021847@harpo.it.uu.se>
Thanks, looks good.
Anton
--
From: Mikael Pettersson <mikpe@csd.uu.se>
Compiling 2.6.12-rc1 or 2.6.12-rc1-mm1 for ppc64 with gcc4
fails with:
In file included from include/asm/spinlock.h:20,
from include/linux/spinlock.h:43,
from include/linux/signal.h:5,
from arch/ppc64/kernel/asm-offsets.c:17:
include/asm/paca.h:25: error: array type has incomplete element type
make[1]: *** [arch/ppc64/kernel/asm-offsets.s] Error 1
make: *** [arch/ppc64/kernel/asm-offsets.s] Error 2
This is an array-of-incomplete-type error.
Fix: move array decl to after the struct decl.
Signed-off-by: Mikael Pettersson <mikpe@csd.uu.se>
Signed-off-by: Anton Blanchard <anton@samba.org>
--- linux-2.6.12-rc1/include/asm-ppc64/paca.h.~1~ 2005-03-02 19:24:19.000000000 +0100
+++ linux-2.6.12-rc1/include/asm-ppc64/paca.h 2005-03-21 15:29:26.000000000 +0100
@@ -22,7 +22,6 @@
#include <asm/iSeries/ItLpRegSave.h>
#include <asm/mmu.h>
-extern struct paca_struct paca[];
register struct paca_struct *local_paca asm("r13");
#define get_paca() local_paca
@@ -115,4 +114,6 @@ struct paca_struct {
#endif
};
+extern struct paca_struct paca[];
+
#endif /* _PPC64_PACA_H */
prev parent reply other threads:[~2005-03-21 17:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-21 15:18 [PATCH][2.6.12-rc1] fix gcc4 compile error in ppc64 paca.h Mikael Pettersson
2005-03-21 17:48 ` Anton Blanchard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050321174823.GC23908@krispykreme \
--to=anton@samba.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc64-dev@ozlabs.org \
--cc=mikpe@csd.uu.se \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox