Re: [PATCH] NMI handler message passing / work deferral API

[Andi Kleen <ak@muc.de>]

On Mon, Mar 21, 2005 at 11:03:56AM -0800, Dave Peterson wrote:
> On Monday 21 March 2005 07:08 am, Andi Kleen wrote:
> > Dave Peterson <dave_peterson@pobox.com> writes:
> > > Below is an experimental 2.6.11.5 kernel patch that implements the
> > > following:
> > >
> > >      - A generic mechanism for safely passing information from NMI
> > > handlers to code that executes outside NMI context.
> >
> > See the machine check queueing implementation in
> > arch/x86_64/kernel/mce.c. It does exactly that already.
> >
> > Several other architectures already have similar mechanisms.
> >
> > -Andi
> 
> Yes exactly.  That's one reason why I posted the patch.  Different
> sybsystems that need this type of functionality shouldn't have to
> individually reinvent the wheel.  With a single implementation, code
> is more compact and easier to understand and maintain.  I would argue

More compact? Sorry, but even all existing implementations together
are still far less code than your really complicated subsystem which
seems quite overengineered for this simple task for me.

Also lockless programming is tricky and I would feel quite uneasy
about auditing so much code.

> that code maintenance is of particular concern to code such as NMI
> and machine check handlers because bugs in this type of code can be
> hard to track down.

Yeah, that is why we use simple, not complex, code in there.

-Andi