From: Nathan Lynch <ntl@pobox.com>
To: Paul Mackerras <paulus@samba.org>
Cc: Mikael Pettersson <mikpe@csd.uu.se>,
akpm@osdl.org, linuxppc64-dev@ozlabs.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][2.6.12-rc1-mm1] fix compile error in ppc64 prom.c
Date: Mon, 21 Mar 2005 16:56:26 -0600 [thread overview]
Message-ID: <20050321225626.GD16469@otto> (raw)
In-Reply-To: <16959.17091.901784.666693@cargo.ozlabs.ibm.com>
On Tue, Mar 22, 2005 at 08:55:15AM +1100, Paul Mackerras wrote:
> Mikael Pettersson writes:
>
> > Compiling 2.6.12-rc1-mm1 for ppc64 fails with:
> >
> > arch/ppc64/kernel/prom.c:1691: error: syntax error before 'prom_reconfig_notifier'
>
> Currently prom.c is in a mess because Linus applied the last 2 of 8
> patches from Nathan Lynch but not the first 6. :-P
Actually, this one is my fault, although unless I'm really missing
something gcc 3.4.2 silently accepts the invalid syntax.
All eight of the patches from the pSeries reconfig series are present
in 2.6.12-rc1-mm1. The error Mikael reported is unrelated to the
state of Linus' tree, and his patch is correct. (The mistake is
present in both versions of the patches which I posted for review on
linuxppc64-dev; nobody caught it.)
Nathan
prev parent reply other threads:[~2005-03-21 23:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-21 15:19 [PATCH][2.6.12-rc1-mm1] fix compile error in ppc64 prom.c Mikael Pettersson
2005-03-21 16:45 ` Nathan Lynch
2005-03-21 21:55 ` Paul Mackerras
2005-03-21 22:56 ` Nathan Lynch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050321225626.GD16469@otto \
--to=ntl@pobox.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc64-dev@ozlabs.org \
--cc=mikpe@csd.uu.se \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox