Re: [-mm patch] drivers/net/chelsio/osdep.h: small cleanups

Christoph Lameter
2005-03-24T03:40:38Z

We just send an update to Andrew and Jeff that also fixes this issue.
Sadly that patch is >300k so we cannot post it to the list.

On Thu, 24 Mar 2005, Adrian Bunk wrote:

> The #define MODVERSIONS doesn't make sense.
>
> And there's no need to #ifdef an #include <linux/module.h>.
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
>
> --- linux-2.6.12-rc1-mm1-full/drivers/net/chelsio/osdep.h.old 2005-03-24 01:20:02.000000000 +0100
> +++ linux-2.6.12-rc1-mm1-full/drivers/net/chelsio/osdep.h 2005-03-24 01:20:17.000000000 +0100
> @@ -33,13 +33,7 @@
> #define __CHELSIO_OSDEP_H
>
> #include <linux/version.h>
> -#if defined(MODULE) && ! defined(MODVERSIONS)
> -#define MODVERSIONS
> -#endif
> -#ifdef MODULE
> #include <linux/module.h>
> -#endif
> -
> #include <linux/config.h>
> #include <linux/types.h>
> #include <linux/delay.h>
>
>