Re: 2.6.12-rc1-mm1: REISER4_FS <-> 4KSTACKS

Adrian Bunk
2005-03-22T19:17:09Z

On Tue, Mar 22, 2005 at 07:56:05PM +0100, Jörn Engel wrote:
> On Tue, 22 March 2005 18:13:40 +0100, Adrian Bunk wrote:
> >
> > REISER4_FS is the only option with a dependency on !4KSTACKS which is
> > bad since 8 kB stacks on i386 won't stay forever.
> >
> > Could fix the problems with 4 kB stacks?
> >
> > Running
> >
> > make checkstacks | grep reiser4
> >
> > inside te kernel sources after compiling gives you hints where problems
> > might come from.
>
> Actually, I've run the Big Ol' checkstack program on reiser4 once.
> Without recursions, the code is well below 3k, but some of the
> recursions look a bit daunting. Here is the relevant output:
>...
> 404 jnode_flush
>...
> 460 rename_hashed
>...
> 224 coord_by_key
>...

These would have been missed by the grep I suggested due to the missing
reiser4_ prefix.

> 208 locks_remove_flock
>...

That seems to be a generic issue in fs/locks.c .
It seems this is the "struct file_lock fl"?

> Jörn

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed