public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [2.6 patch] drivers/scsi/osst.c: make code static
@ 2005-02-28 20:56 Adrian Bunk
  0 siblings, 0 replies; 3+ messages in thread
From: Adrian Bunk @ 2005-02-28 20:56 UTC (permalink / raw)
  To: osst; +Cc: osst-users, James.Bottomley, linux-scsi, linux-kernel

This patch makes needlessly global code static.

Signed-off-by: Adrian Bunk <bunk@stusta.de>

---

 drivers/scsi/osst.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

--- linux-2.6.11-rc4-mm1-full/drivers/scsi/osst.c.old	2005-02-28 19:36:05.000000000 +0100
+++ linux-2.6.11-rc4-mm1-full/drivers/scsi/osst.c	2005-02-28 19:36:25.000000000 +0100
@@ -24,7 +24,7 @@
 */
 
 static const char * cvsid = "$Id: osst.c,v 1.73 2005/01/01 21:13:34 wriede Exp $";
-const char * osst_version = "0.99.3";
+static const char * osst_version = "0.99.3";
 
 /* The "failure to reconnect" firmware bug */
 #define OSST_FW_NEED_POLL_MIN 10601 /*(107A)*/
@@ -170,7 +170,7 @@
 static int osst_probe(struct device *);
 static int osst_remove(struct device *);
 
-struct scsi_driver osst_template = {
+static struct scsi_driver osst_template = {
 	.owner			= THIS_MODULE,
 	.gendrv = {
 		.name		=  "osst",


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [2.6 patch] drivers/scsi/osst.c: make code static
@ 2005-03-22 14:28 Adrian Bunk
  2005-03-22 21:19 ` Willem Riede
  0 siblings, 1 reply; 3+ messages in thread
From: Adrian Bunk @ 2005-03-22 14:28 UTC (permalink / raw)
  To: Andrew Morton; +Cc: osst, osst-users, James.Bottomley, linux-scsi, linux-kernel

This patch makes needlessly global code static.

Signed-off-by: Adrian Bunk <bunk@stusta.de>

---

This patch was already sent on:
- 28 Feb 2005

 drivers/scsi/osst.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

--- linux-2.6.11-rc4-mm1-full/drivers/scsi/osst.c.old	2005-02-28 19:36:05.000000000 +0100
+++ linux-2.6.11-rc4-mm1-full/drivers/scsi/osst.c	2005-02-28 19:36:25.000000000 +0100
@@ -24,7 +24,7 @@
 */
 
 static const char * cvsid = "$Id: osst.c,v 1.73 2005/01/01 21:13:34 wriede Exp $";
-const char * osst_version = "0.99.3";
+static const char * osst_version = "0.99.3";
 
 /* The "failure to reconnect" firmware bug */
 #define OSST_FW_NEED_POLL_MIN 10601 /*(107A)*/
@@ -170,7 +170,7 @@
 static int osst_probe(struct device *);
 static int osst_remove(struct device *);
 
-struct scsi_driver osst_template = {
+static struct scsi_driver osst_template = {
 	.owner			= THIS_MODULE,
 	.gendrv = {
 		.name		=  "osst",


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [2.6 patch] drivers/scsi/osst.c: make code static
  2005-03-22 14:28 [2.6 patch] drivers/scsi/osst.c: make code static Adrian Bunk
@ 2005-03-22 21:19 ` Willem Riede
  0 siblings, 0 replies; 3+ messages in thread
From: Willem Riede @ 2005-03-22 21:19 UTC (permalink / raw)
  To: James.Bottomley, Adrian Bunk
  Cc: Andrew Morton, osst-users, linux-scsi, linux-kernel

On 03/22/2005 09:28:07 AM, Adrian Bunk wrote:
> This patch makes needlessly global code static.
> 
> Signed-off-by: Adrian Bunk <bunk@stusta.de>

James, I agree with this, can you put it in BK, please?

Signed-off-by: Willem Riede <osst@riede.org>
 
> ---
> 
> This patch was already sent on:
> - 28 Feb 2005
> 
>  drivers/scsi/osst.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> --- linux-2.6.11-rc4-mm1-full/drivers/scsi/osst.c.old	2005-02-28 19:36:05.000000000 +0100
> +++ linux-2.6.11-rc4-mm1-full/drivers/scsi/osst.c	2005-02-28 19:36:25.000000000 +0100
> @@ -24,7 +24,7 @@
>  */
>  
>  static const char * cvsid = "$Id: osst.c,v 1.73 2005/01/01 21:13:34 wriede Exp $";
> -const char * osst_version = "0.99.3";
> +static const char * osst_version = "0.99.3";
>  
>  /* The "failure to reconnect" firmware bug */
>  #define OSST_FW_NEED_POLL_MIN 10601 /*(107A)*/
> @@ -170,7 +170,7 @@
>  static int osst_probe(struct device *);
>  static int osst_remove(struct device *);
>  
> -struct scsi_driver osst_template = {
> +static struct scsi_driver osst_template = {
>  	.owner			= THIS_MODULE,
>  	.gendrv = {
>  		.name		=  "osst",
> 



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2005-03-22 21:20 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-03-22 14:28 [2.6 patch] drivers/scsi/osst.c: make code static Adrian Bunk
2005-03-22 21:19 ` Willem Riede
  -- strict thread matches above, loose matches on Subject: below --
2005-02-28 20:56 Adrian Bunk

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox