From: Adrian Bunk <bunk@stusta.de>
To: jgarzik@pobox.com
Cc: linux-net@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [2.6 patch] drivers/net/eql.c: kill dead code
Date: Tue, 22 Mar 2005 22:53:54 +0100 [thread overview]
Message-ID: <20050322215354.GM1948@stusta.de> (raw)
This patch removes some obviously dead code found by the Coverity
checker.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.12-rc1-mm1-full/drivers/net/eql.c.old 2005-03-22 21:20:24.000000000 +0100
+++ linux-2.6.12-rc1-mm1-full/drivers/net/eql.c 2005-03-22 21:23:19.000000000 +0100
@@ -498,10 +498,8 @@
if (!slave_dev)
return -ENODEV;
ret = -EINVAL;
- if (!slave_dev)
- return ret;
spin_lock_bh(&eql->queue.lock);
if (eql_is_slave(slave_dev)) {
slave = __eql_find_slave_dev(&eql->queue, slave_dev);
@@ -535,10 +533,8 @@
if (!slave_dev)
return -ENODEV;
ret = -EINVAL;
- if (!slave_dev)
- return ret;
eql = netdev_priv(dev);
spin_lock_bh(&eql->queue.lock);
if (eql_is_slave(slave_dev)) {
next reply other threads:[~2005-03-22 21:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-22 21:53 Adrian Bunk [this message]
2005-03-23 20:22 ` [2.6 patch] drivers/net/eql.c: kill dead code David S. Miller
2005-03-23 20:28 ` Jeff Garzik
2005-03-23 21:01 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050322215354.GM1948@stusta.de \
--to=bunk@stusta.de \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-net@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox