* [2.6 patch] drivers/net/eql.c: kill dead code
@ 2005-03-22 21:53 Adrian Bunk
2005-03-23 20:22 ` David S. Miller
0 siblings, 1 reply; 4+ messages in thread
From: Adrian Bunk @ 2005-03-22 21:53 UTC (permalink / raw)
To: jgarzik; +Cc: linux-net, linux-kernel
This patch removes some obviously dead code found by the Coverity
checker.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.12-rc1-mm1-full/drivers/net/eql.c.old 2005-03-22 21:20:24.000000000 +0100
+++ linux-2.6.12-rc1-mm1-full/drivers/net/eql.c 2005-03-22 21:23:19.000000000 +0100
@@ -498,10 +498,8 @@
if (!slave_dev)
return -ENODEV;
ret = -EINVAL;
- if (!slave_dev)
- return ret;
spin_lock_bh(&eql->queue.lock);
if (eql_is_slave(slave_dev)) {
slave = __eql_find_slave_dev(&eql->queue, slave_dev);
@@ -535,10 +533,8 @@
if (!slave_dev)
return -ENODEV;
ret = -EINVAL;
- if (!slave_dev)
- return ret;
eql = netdev_priv(dev);
spin_lock_bh(&eql->queue.lock);
if (eql_is_slave(slave_dev)) {
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [2.6 patch] drivers/net/eql.c: kill dead code
2005-03-22 21:53 [2.6 patch] drivers/net/eql.c: kill dead code Adrian Bunk
@ 2005-03-23 20:22 ` David S. Miller
2005-03-23 20:28 ` Jeff Garzik
0 siblings, 1 reply; 4+ messages in thread
From: David S. Miller @ 2005-03-23 20:22 UTC (permalink / raw)
To: Adrian Bunk; +Cc: jgarzik, linux-net, linux-kernel
On Tue, 22 Mar 2005 22:53:54 +0100
Adrian Bunk <bunk@stusta.de> wrote:
> This patch removes some obviously dead code found by the Coverity
> checker.
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
Applied, thanks Adrian.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [2.6 patch] drivers/net/eql.c: kill dead code
2005-03-23 20:22 ` David S. Miller
@ 2005-03-23 20:28 ` Jeff Garzik
2005-03-23 21:01 ` David S. Miller
0 siblings, 1 reply; 4+ messages in thread
From: Jeff Garzik @ 2005-03-23 20:28 UTC (permalink / raw)
To: David S. Miller; +Cc: Adrian Bunk, linux-net, linux-kernel
On Wed, Mar 23, 2005 at 12:22:12PM -0800, David S. Miller wrote:
> On Tue, 22 Mar 2005 22:53:54 +0100
> Adrian Bunk <bunk@stusta.de> wrote:
>
> > This patch removes some obviously dead code found by the Coverity
> > checker.
> >
> > Signed-off-by: Adrian Bunk <bunk@stusta.de>
>
> Applied, thanks Adrian.
Note that I apply drivers/net/* stuff too, including this one... :)
http://marc.theaimsgroup.com/?l=linux-kernel&m=111154928104675&w=2
Jeff
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [2.6 patch] drivers/net/eql.c: kill dead code
2005-03-23 20:28 ` Jeff Garzik
@ 2005-03-23 21:01 ` David S. Miller
0 siblings, 0 replies; 4+ messages in thread
From: David S. Miller @ 2005-03-23 21:01 UTC (permalink / raw)
To: Jeff Garzik; +Cc: bunk, linux-net, linux-kernel
On Wed, 23 Mar 2005 15:28:23 -0500
Jeff Garzik <jgarzik@pobox.com> wrote:
> Note that I apply drivers/net/* stuff too, including this one... :)
I realized this was a possibility, BK will figure it out once
it gets merged so no worries.
Generally, besides bonding, I pretty much take the changes in
for non-hardware drivers like eql, shaper, and friends.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2005-03-23 21:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-03-22 21:53 [2.6 patch] drivers/net/eql.c: kill dead code Adrian Bunk
2005-03-23 20:22 ` David S. Miller
2005-03-23 20:28 ` Jeff Garzik
2005-03-23 21:01 ` David S. Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox