* [RFC: 2.6 patch] drivers/net/ns83820.c: remove unused code
@ 2005-03-22 21:57 Adrian Bunk
2005-04-01 20:55 ` Benjamin LaHaise
0 siblings, 1 reply; 2+ messages in thread
From: Adrian Bunk @ 2005-03-22 21:57 UTC (permalink / raw)
To: linux-ns83820; +Cc: jgarzik, linux-net, linux-kernel
The Coveity checker found that residue is always 0.
Is this patch correct or should residue have been used?
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.12-rc1-mm1-full/drivers/net/ns83820.c.old 2005-03-22 21:32:15.000000000 +0100
+++ linux-2.6.12-rc1-mm1-full/drivers/net/ns83820.c 2005-03-22 21:33:16.000000000 +0100
@@ -1189,7 +1189,6 @@
for (;;) {
volatile u32 *desc = dev->tx_descs + (free_idx * DESC_SIZE);
- u32 residue = 0;
dprintk("frag[%3u]: %4u @ 0x%08Lx\n", free_idx, len,
(unsigned long long)buf);
@@ -1199,17 +1198,11 @@
desc_addr_set(desc + DESC_BUFPTR, buf);
desc[DESC_EXTSTS] = cpu_to_le32(extsts);
- cmdsts = ((nr_frags|residue) ? CMDSTS_MORE : do_intr ? CMDSTS_INTR : 0);
+ cmdsts = ((nr_frags) ? CMDSTS_MORE : do_intr ? CMDSTS_INTR : 0);
cmdsts |= (desc == first_desc) ? 0 : CMDSTS_OWN;
cmdsts |= len;
desc[DESC_CMDSTS] = cpu_to_le32(cmdsts);
- if (residue) {
- buf += len;
- len = residue;
- continue;
- }
-
if (!nr_frags)
break;
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [RFC: 2.6 patch] drivers/net/ns83820.c: remove unused code
2005-03-22 21:57 [RFC: 2.6 patch] drivers/net/ns83820.c: remove unused code Adrian Bunk
@ 2005-04-01 20:55 ` Benjamin LaHaise
0 siblings, 0 replies; 2+ messages in thread
From: Benjamin LaHaise @ 2005-04-01 20:55 UTC (permalink / raw)
To: Adrian Bunk; +Cc: linux-ns83820, jgarzik, linux-net, linux-kernel
applied
On Tue, Mar 22, 2005 at 10:57:17PM +0100, Adrian Bunk wrote:
> The Coveity checker found that residue is always 0.
>
> Is this patch correct or should residue have been used?
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
>
> --- linux-2.6.12-rc1-mm1-full/drivers/net/ns83820.c.old 2005-03-22 21:32:15.000000000 +0100
> +++ linux-2.6.12-rc1-mm1-full/drivers/net/ns83820.c 2005-03-22 21:33:16.000000000 +0100
> @@ -1189,7 +1189,6 @@
>
> for (;;) {
> volatile u32 *desc = dev->tx_descs + (free_idx * DESC_SIZE);
> - u32 residue = 0;
>
> dprintk("frag[%3u]: %4u @ 0x%08Lx\n", free_idx, len,
> (unsigned long long)buf);
> @@ -1199,17 +1198,11 @@
> desc_addr_set(desc + DESC_BUFPTR, buf);
> desc[DESC_EXTSTS] = cpu_to_le32(extsts);
>
> - cmdsts = ((nr_frags|residue) ? CMDSTS_MORE : do_intr ? CMDSTS_INTR : 0);
> + cmdsts = ((nr_frags) ? CMDSTS_MORE : do_intr ? CMDSTS_INTR : 0);
> cmdsts |= (desc == first_desc) ? 0 : CMDSTS_OWN;
> cmdsts |= len;
> desc[DESC_CMDSTS] = cpu_to_le32(cmdsts);
>
> - if (residue) {
> - buf += len;
> - len = residue;
> - continue;
> - }
> -
> if (!nr_frags)
> break;
>
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-ns83820' in
> the body to majordomo@kvack.org.
--
"Time is what keeps everything from happening all at once." -- John Wheeler
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-04-01 21:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-03-22 21:57 [RFC: 2.6 patch] drivers/net/ns83820.c: remove unused code Adrian Bunk
2005-04-01 20:55 ` Benjamin LaHaise
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox