Re: [2.6 patch] drivers/input/serio/libps2.c: ps2_command: add a missing check

Adrian Bunk
2005-03-25T00:48:39Z

On Thu, Mar 24, 2005 at 04:39:31PM -0500, Dmitry Torokhov wrote:
>
> Yes, if it will make the checker happy. Although I (and this is
> probably just me) use BUG_ON only if kernel would not OOPS otherwise,
> to avoid scribbling over random memory and such.

I don't whether it would make the checker happy (and I don't care much).

It would IMHO make the code better understandable.

But I don't have a very strong opinion on this issue.

> Dmitry

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed