From: Adrian Bunk <bunk@stusta.de>
To: dmo@osdl.org
Cc: linux-kernel@vger.kernel.org
Subject: [2.6 patch] drivers/block/DAC960.c: fix a use after free
Date: Thu, 24 Mar 2005 02:14:14 +0100 [thread overview]
Message-ID: <20050324011414.GJ1948@stusta.de> (raw)
This patch fixes a use after free found by the Coverity checker.
Controller is used in the Failure path.
In the Failure patch, Controller will be freed in the end, so this kfree
can simply be deleted.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.12-rc1-mm1-full/drivers/block/DAC960.c.old 2005-03-23 03:35:40.000000000 +0100
+++ linux-2.6.12-rc1-mm1-full/drivers/block/DAC960.c 2005-03-23 03:38:10.000000000 +0100
@@ -2700,10 +2700,8 @@
Controller->PCIDevice = PCI_Device;
strcpy(Controller->FullModelName, "DAC960");
- if (pci_enable_device(PCI_Device)) {
- kfree(Controller);
+ if (pci_enable_device(PCI_Device))
goto Failure;
- }
switch (Controller->HardwareType)
{
reply other threads:[~2005-03-24 1:14 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050324011414.GJ1948@stusta.de \
--to=bunk@stusta.de \
--cc=dmo@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox