* [2.6 patch] drivers/input/joystick/iforce/iforce-main.c: fix check after use
@ 2005-03-24 3:12 Adrian Bunk
0 siblings, 0 replies; only message in thread
From: Adrian Bunk @ 2005-03-24 3:12 UTC (permalink / raw)
To: vojtech; +Cc: linux-joystick, linux-kernel
This patch fixes an obvious check after use found by the Coverity
checker.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.12-rc1-mm1-full/drivers/input/joystick/iforce/iforce-main.c.old 2005-03-24 02:28:48.000000000 +0100
+++ linux-2.6.12-rc1-mm1-full/drivers/input/joystick/iforce/iforce-main.c 2005-03-24 02:29:15.000000000 +0100
@@ -221,15 +221,15 @@ static int iforce_erase_effect(struct in
int err = 0;
struct iforce_core_effect* core_effect;
+ if (effect_id < 0 || effect_id >= FF_EFFECTS_MAX)
+ return -EINVAL;
+
/* Check who is trying to erase this effect */
if (iforce->core_effects[effect_id].owner != current->pid) {
printk(KERN_WARNING "iforce-main.c: %d tried to erase an effect belonging to %d\n", current->pid, iforce->core_effects[effect_id].owner);
return -EACCES;
}
- if (effect_id < 0 || effect_id >= FF_EFFECTS_MAX)
- return -EINVAL;
-
core_effect = iforce->core_effects + effect_id;
if (test_bit(FF_MOD1_IS_USED, core_effect->flags))
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2005-03-24 3:14 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-03-24 3:12 [2.6 patch] drivers/input/joystick/iforce/iforce-main.c: fix check after use Adrian Bunk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox