Re: [PATCH 0/5] I8K driver facelift

Dmitry Torokhov
2005-03-24T14:44:14Z

On Thu, 24 Mar 2005 00:00:48 -0800, Greg KH <greg@kroah.com> wrote:
> On Thu, Mar 24, 2005 at 02:39:32AM -0500, Dmitry Torokhov wrote:
> > On Thursday 24 March 2005 02:25, Greg KH wrote:
> > > On Thu, Mar 17, 2005 at 01:40:48AM -0500, Dmitry Torokhov wrote:
> > > > On Wednesday 16 March 2005 16:38, Frank Sorenson wrote:
> > > > > Okay, I replaced the sysfs_ops with ops of my own, and now all the show
> > > > > and store functions also accept the name of the attribute as a parameter.
> > > > > This lets the functions know what attribute is being accessed, and allows
> > > > > us to create attributes that share show and store functions, so things
> > > > > don't need to be defined at compile time (I feel slightly evil!).
> > > >
> > > > Hrm, can we be a little more explicit and not poke in the sysfs guts right
> > > > in the driver? What do you think about the patch below athat implements
> > > > "attribute arrays"? And I am attaching cumulative i8k patch using these
> > > > arrays so they can be tested.
> > > >
> > > > I am CC-ing Greg to see what he thinks about it.
> > >
> > > Hm, I think it's proably of limited use, right? What other code would
> > > want this (the i2c sensor code doesn't, as it's naming scheme is
> > > different.)
> > >
> >
> > Looking at their attributes they would benefit from arrays of goups of
> > attributes... They have:
> > ...
> Yeah, but then you break the userspace api that tools are already
> expecting to see :(
>

Yes, although i2c did change inreface somewhat recently - I remember I
had to upgrade sensor package couple of month ago to get sensors
output, so we have some precedent.

Also, even if i2c decides not to use it it does not mean that at some
point nobody else would use attribute arrays and arrays of groups. I
am willing to bet if these would be available they could be used:

/drivers/macintosh/therm_pm72.c
/drivers/usb/misc/cytherm.c

Attributes with a private pointer passed in would be very useful too.

--
Dmitry