From: David Brownell <david-b@pacbell.net>
To: Jakemuksen spammiosote <jhroska@byterapers.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usbnet.c, buf.overrun crash-bugfix, Kernel 2.6.12-rc1
Date: Thu, 24 Mar 2005 10:23:26 -0800 [thread overview]
Message-ID: <200503241023.26308.david-b@pacbell.net> (raw)
In-Reply-To: <Pine.LNX.4.61.0503242006160.767@byterapers.com>
On Thursday 24 March 2005 10:13 am, Jakemuksen spammiosote wrote:
> On Thu, 24 Mar 2005, David Brownell wrote:
> > On Thursday 24 March 2005 8:05 am, Jakemuksen spammiosote wrote:
>
> >> + if (unlikely((skb->tail + urb->actual_length) > skb->end)) {
> >
> > This logic looks wrong. If that ever happens, surely the problem is
> > that the rx_submit() code submitted an urb with transfer_size that
> > mismatched the SKB. The host controller isn't allowed to overrun the
>
> Sounds reasonable. So, I'll go thru the HCD code
Better yet, start with the code supporting that device you're
under NDA for.
> instead if the
> responsibility is there. Am i the first one to run into such crash
> situation? If so, perhaps it's not ever worthy to fix in mainstream
> kernel, as the device causes the crash under very specific -
> 'abusing' one might say, situation only.
You're the first one to report such a problem.
- Dave
prev parent reply other threads:[~2005-03-24 18:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-24 16:05 [PATCH] usbnet.c, buf.overrun crash-bugfix, Kernel 2.6.12-rc1 Jakemuksen spammiosote
2005-03-24 16:57 ` David Brownell
2005-03-24 18:13 ` Jakemuksen spammiosote
2005-03-24 18:23 ` David Brownell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200503241023.26308.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=jhroska@byterapers.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox