Re: drm bugs hopefully fixed but there might still be one..

cliff white
2005-03-24T23:05:16Z

On Thu, 24 Mar 2005 14:21:31 -0800
Andrew Morton <akpm@osdl.org> wrote:

> cliff white <cliffw@osdl.org> wrote:
> >
> > Okay, i have a iBook G4, with radeon, with 2.6.12-rc1-mm2, i'm getting the following OOPS
> > on boot.
>
> Please try reverting agp-make-some-code-static.patch (Dunno why that would
> fix an oops, but apparently it does).
>
It does the same thing Brice's fix does. Need to put the
one extern struct definition back in agp_backend.h and that is the badness:

diff -puN include/linux/agp_backend.h~agp-make-some-code-static include/linux/agp_backend.h
--- 25/include/linux/agp_backend.h~agp-make-some-code-static 2005-03-21 21:53:17.000000000 -0800
+++ 25-akpm/include/linux/agp_backend.h 2005-03-21 21:53:17.000000000 -0800
@@ -94,8 +94,6 @@ struct agp_memory {
extern struct agp_bridge_data *agp_bridge;
extern struct list_head agp_bridges;

-extern struct agp_bridge_data *(*agp_find_bridge)(struct pci_dev *);
-
extern void agp_free_memory(struct agp_memory *);
extern struct agp_memory *agp_allocate_memory(struct agp_bridge_data *, size_t, u32);
extern int agp_copy_info(struct agp_bridge_data *, struct agp_kern_info *);
_
----------
cliffw

--
"Ive always gone through periods where I bolt upright at four in the morning;
now at least theres a reason." -Michael Feldman