Re: drm bugs hopefully fixed but there might still be one..

Jesse Barnes
2005-03-24T18:40:10Z

On Thursday, March 24, 2005 10:18 am, Dave Jones wrote:
> > I'm trying to get ahold of one--so hopefully I'll be able to test and
> > fix this stuff up when I do.
>
> Aparently backing out the changes to via's tlb_flush routine fixed it
> for one VIA user. I've not had a chance to look into it just yet.
> Worse case we can just drop those changes for 2.6.12

You mean these changes?

--- a/drivers/char/agp/via-agp.c 2005-03-24 10:33:45 -08:00
+++ b/drivers/char/agp/via-agp.c 2005-03-24 10:33:45 -08:00
@@ -83,8 +83,10 @@

pci_read_config_dword(agp_bridge->dev, VIA_GARTCTRL, &temp);
temp |= (1<<7);
+ temp &= ~0x7f;
pci_write_config_dword(agp_bridge->dev, VIA_GARTCTRL, temp);
temp &= ~(1<<7);
+ temp &= ~0x7f;
pci_write_config_dword(agp_bridge->dev, VIA_GARTCTRL, temp);
}

I'll ask Markus to try reverting this since I still don't have a machine
setup. It sounds like a possibility given what he's seeing.

Jesse