From: Andrew Morton <akpm@osdl.org>
To: cliff white <cliffw@osdl.org>
Cc: airlied@linux.ie, davej@redhat.com, linux-kernel@vger.kernel.org,
dri-devel@lists.sourceforge.net
Subject: Re: drm bugs hopefully fixed but there might still be one..
Date: Thu, 24 Mar 2005 15:12:20 -0800 [thread overview]
Message-ID: <20050324151220.5e5f3d5f.akpm@osdl.org> (raw)
In-Reply-To: <20050324150450.01fbf17f@es175>
cliff white <cliffw@osdl.org> wrote:
>
> -extern struct agp_bridge_data *(*agp_find_bridge)(struct pci_dev *);
> -
Oh crap, so the compiler decided that agp_find_bridge() was a function and
decided to jump to it, rather than reading from it and doing an indirect
jump. Yup, that'll crash it. Sorry about that.
This is another reason why doing the old-style
(*agp_find_bridge)(...);
is better than doing the new-style
agp_find_bridge(...);
The former case won't even compile, and is more readable.
next prev parent reply other threads:[~2005-03-24 23:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-24 10:33 drm bugs hopefully fixed but there might still be one Dave Airlie
2005-03-24 11:04 ` Andrew Morton
2005-03-24 17:02 ` Jesse Barnes
2005-03-24 18:18 ` Dave Jones
2005-03-24 18:35 ` Jesse Barnes
2005-03-24 21:58 ` cliff white
2005-03-24 22:21 ` Andrew Morton
2005-03-24 23:04 ` cliff white
2005-03-24 23:12 ` Andrew Morton [this message]
[not found] <3LxV3-5Is-25@gated-at.bofh.it>
[not found] ` <3LE0y-2Kn-55@gated-at.bofh.it>
[not found] ` <3LFg5-3MJ-37@gated-at.bofh.it>
[not found] ` <3LFzj-40t-15@gated-at.bofh.it>
2005-03-24 20:09 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050324151220.5e5f3d5f.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=airlied@linux.ie \
--cc=cliffw@osdl.org \
--cc=davej@redhat.com \
--cc=dri-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox