From: "David S. Miller" <davem@davemloft.net>
To: Christoph Lameter <clameter@engr.sgi.com>
Cc: davidm@hpl.hp.com, ak@muc.de, clameter@sgi.com,
vda@port.imtp.ilyichevsk.odessa.ua, haveblue@us.ibm.com,
akpm@osdl.org, linux-kernel@vger.kernel.org, mel@csn.ul.ie,
linux-ia64@vger.kernel.org, Jens.Maurer@gmx.net
Subject: Re: [PATCH] add a clear_pages function to clear pages of higher order
Date: Thu, 24 Mar 2005 15:13:50 -0800 [thread overview]
Message-ID: <20050324151350.5801ee10.davem@davemloft.net> (raw)
In-Reply-To: <Pine.LNX.4.58.0503241449070.7119@schroedinger.engr.sgi.com>
On Thu, 24 Mar 2005 14:49:55 -0800 (PST)
Christoph Lameter <clameter@engr.sgi.com> wrote:
> On Thu, 24 Mar 2005, David S. Miller wrote:
>
> > > prep_zero_page would use a temporal clear for an order 0 page but a
> > > nontemporal clear for higher order pages.
> >
> > That sounds about right to me.
> >
> > Hmmm, I'm inspired to experiment with this on sparc64 a bit.
>
> Could you help me fix up this patch replacing the old clear_pages patch?
Sure, I'll play with it.
Meanwhile, here are some numbers. I changed just the clear_page()
implementation on sparc64 so that it used prefetching and normal
temporal stores. The machine is a uniprocessor 1.5Ghz Ultra-IIIi,
64K write-through D-cache, 64K I-cache, 1MB L2 cache. I did 4
timed 'vmlinux' builds after a fresh boot:
BEFORE:
real 9m8.720s
user 8m28.345s
sys 0m32.734s
real 9m2.034s
user 8m28.763s
sys 0m32.512s
real 9m1.848s
user 8m28.970s
sys 0m32.204s
real 9m1.701s
user 8m28.715s
sys 0m32.394s
AFTER:
real 9m2.241s
user 8m16.633s
sys 0m36.451s
real 8m53.739s
user 8m17.165s
sys 0m36.052s
real 8m54.089s
user 8m17.266s
sys 0m36.219s
real 8m54.071s
user 8m17.473s
sys 0m36.073s
So, at the very least, my results agree with D. Mosberger's on IA64.
At the cost of ~4 seconds of system time, we gain ~11 seconds of
user time.
I'm pretty much convinced this is a win. I wonder if it matters to
do something similar for copy_page*() as well.
next prev parent reply other threads:[~2005-03-24 23:20 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-10 20:35 [PATCH] add a clear_pages function to clear pages of higher order Christoph Lameter
2005-03-10 21:38 ` Dave Hansen
2005-03-10 22:46 ` Christoph Lameter
2005-03-11 1:03 ` Christoph Lameter
2005-03-11 8:08 ` Denis Vlasenko
2005-03-17 1:33 ` Christoph Lameter
2005-03-18 9:54 ` Denis Vlasenko
2005-03-18 15:00 ` Christoph Lameter
2005-03-18 19:28 ` Andi Kleen
2005-03-18 20:19 ` Christoph Lameter
2005-03-21 15:30 ` Denis Vlasenko
2005-03-24 18:34 ` David Mosberger
2005-03-24 18:41 ` Christoph Lameter
2005-03-24 19:03 ` David S. Miller
2005-03-24 22:49 ` Christoph Lameter
2005-03-24 23:13 ` David S. Miller [this message]
2005-03-25 2:29 ` David S. Miller
2005-03-25 2:43 ` Christoph Lameter
2005-03-27 17:12 ` Andi Kleen
2005-03-27 18:23 ` David S. Miller
2005-03-29 1:58 ` Christoph Lameter
2005-04-06 0:15 ` Christoph Lameter
2005-04-06 0:23 ` David Mosberger
2005-04-06 0:33 ` Christoph Lameter
2005-04-06 4:48 ` David Mosberger
2005-04-06 5:15 ` Gerrit Huizenga
2005-04-06 16:03 ` Grant Grundler
2005-03-18 10:12 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050324151350.5801ee10.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Jens.Maurer@gmx.net \
--cc=ak@muc.de \
--cc=akpm@osdl.org \
--cc=clameter@engr.sgi.com \
--cc=clameter@sgi.com \
--cc=davidm@hpl.hp.com \
--cc=haveblue@us.ibm.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mel@csn.ul.ie \
--cc=vda@port.imtp.ilyichevsk.odessa.ua \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox