From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Pierre Ossman <drzeus-list@drzeus.cx>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] wbsd update
Date: Thu, 24 Mar 2005 15:50:14 +0000 [thread overview]
Message-ID: <20050324155014.C4189@flint.arm.linux.org.uk> (raw)
In-Reply-To: <42408E3F.5040509@drzeus.cx>; from drzeus-list@drzeus.cx on Tue, Mar 22, 2005 at 10:29:35PM +0100
On Tue, Mar 22, 2005 at 10:29:35PM +0100, Pierre Ossman wrote:
> @@ -1581,7 +1895,7 @@
> #define wbsd_resume NULL
> #endif
>
> -static void wbsd_release(struct device *dev)
> +static void wbsd_release_dev(struct device *dev)
> {
> }
>
> @@ -1589,7 +1903,7 @@
> .name = DRIVER_NAME,
> .id = -1,
> .dev = {
> - .release = wbsd_release,
> + .release = wbsd_release_dev,
> },
> };
>
Please use platform_device_register_simple() instead of providing a buggy
release function.
> @@ -133,13 +139,20 @@
> #define WBSD_CRC_OK 0x05 /* S010E (00101) */
> #define WBSD_CRC_FAIL 0x0B /* S101E (01011) */
>
> +#define WBSD_DMA_SIZE 65536
>
> struct wbsd_host
> {
> + struct device* dev;
You might like to consider using mmc->dev instead of duplicating it
here.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core
next prev parent reply other threads:[~2005-03-24 15:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-22 21:29 [PATCH] wbsd update Pierre Ossman
2005-03-24 15:50 ` Russell King [this message]
2005-04-01 7:36 ` Pierre Ossman
-- strict thread matches above, loose matches on Subject: below --
2005-01-19 10:41 Pierre Ossman
2005-01-21 11:13 ` Russell King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050324155014.C4189@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=drzeus-list@drzeus.cx \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox