Re: Fw: Re: drm bugs hopefully fixed but there might still be one..

[Dave Jones <davej@redhat.com>]

On Thu, Mar 24, 2005 at 09:09:47PM +0000, Andrew Clayton wrote:
 > On Thu, 2005-03-24 at 12:32 -0800, Andrew Morton wrote:
 > > ?
 > > 
 > > Begin forwarded message:
 > > 
 > 
 > [snip]
 > 
 > > > You mean these changes?
 > > > 
 > > > --- a/drivers/char/agp/via-agp.c        2005-03-24 10:33:45 -08:00
 > > > +++ b/drivers/char/agp/via-agp.c        2005-03-24 10:33:45 -08:00
 > > > @@ -83,8 +83,10 @@
 > > >  
 > > >         pci_read_config_dword(agp_bridge->dev, VIA_GARTCTRL, &temp);
 > > >         temp |= (1<<7);
 > > > +       temp &= ~0x7f;
 > > >         pci_write_config_dword(agp_bridge->dev, VIA_GARTCTRL, temp);
 > > >         temp &= ~(1<<7);
 > > > +       temp &= ~0x7f;
 > > >         pci_write_config_dword(agp_bridge->dev, VIA_GARTCTRL, temp);
 > > >  }
 > > 
 > > Exactlty. I had to revert this one since 2.6.11-bk3, or starting X kills
 > > the machine. By "kill", I mean the real thing, black screen, dead
 > > network, reset is the only choice. This is a (surprise!) VIA-based
 > > motherboard (Asus A7V133-C) with Radeon 9200-based graphics adapter.
 > > Dave Airlie was asking for a tester with such a configuration. I can
 > > test whatever you want. Just tell me what we are looking for :)
 > > 
 > > With the patch above reverted, 2.6.12-rc1-mm2 seems to work just fine
 > > for me. glxgears is OK and I just had a game of UT (first of the name).
 > > However, I am not a regular gamer so I'm not sure what to look for.
 > > 
 > > Thanks,
 > 
 > 
 > Bingo!
 > 
 > Backing out that change to a 2.6.12-rc1 solves the exact same problem
 > I've been having since 2.6.11-bk3. VIA chipset + Radeon 9200SE.
 > 
 > http://www.ussg.iu.edu/hypermail/linux/kernel/0503.1/1096.html

Yes, it's clearly completely broken. Linus, please cset -x that one
from your tree.

		Dave