From: Adrian Bunk <bunk@stusta.de>
To: linux-kernel@vger.kernel.org
Subject: [2.6 patch] sound/oss/gus_wave.c: fix off by one errors
Date: Fri, 25 Mar 2005 19:21:49 +0100 [thread overview]
Message-ID: <20050325182149.GC3153@stusta.de> (raw)
This patch fixes two off by one errors found by the Coverity checker.
In both cases, the variables are later used as indexes for arrays with
MAX_PATCH elements.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.12-rc1-mm1-full/sound/oss/gus_wave.c.old 2005-03-23 03:19:25.000000000 +0100
+++ linux-2.6.12-rc1-mm1-full/sound/oss/gus_wave.c 2005-03-23 03:20:42.000000000 +0100
@@ -1085,7 +1085,7 @@
{
int sample_no;
- if (instr_no < 0 || instr_no > MAX_PATCH)
+ if (instr_no < 0 || instr_no >= MAX_PATCH)
instr_no = 0; /* Default to acoustic piano */
if (voice < 0 || voice > 31)
@@ -1676,7 +1676,7 @@
instr = patch.instr_no;
- if (instr < 0 || instr > MAX_PATCH)
+ if (instr < 0 || instr >= MAX_PATCH)
{
/* printk(KERN_ERR "GUS: Invalid patch number %d\n", instr);*/
return -EINVAL;
reply other threads:[~2005-03-25 18:22 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050325182149.GC3153@stusta.de \
--to=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox