* [2.6 patch] sound/oss/gus_wave.c: fix off by one errors
@ 2005-03-25 18:21 Adrian Bunk
0 siblings, 0 replies; only message in thread
From: Adrian Bunk @ 2005-03-25 18:21 UTC (permalink / raw)
To: linux-kernel
This patch fixes two off by one errors found by the Coverity checker.
In both cases, the variables are later used as indexes for arrays with
MAX_PATCH elements.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.12-rc1-mm1-full/sound/oss/gus_wave.c.old 2005-03-23 03:19:25.000000000 +0100
+++ linux-2.6.12-rc1-mm1-full/sound/oss/gus_wave.c 2005-03-23 03:20:42.000000000 +0100
@@ -1085,7 +1085,7 @@
{
int sample_no;
- if (instr_no < 0 || instr_no > MAX_PATCH)
+ if (instr_no < 0 || instr_no >= MAX_PATCH)
instr_no = 0; /* Default to acoustic piano */
if (voice < 0 || voice > 31)
@@ -1676,7 +1676,7 @@
instr = patch.instr_no;
- if (instr < 0 || instr > MAX_PATCH)
+ if (instr < 0 || instr >= MAX_PATCH)
{
/* printk(KERN_ERR "GUS: Invalid patch number %d\n", instr);*/
return -EINVAL;
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2005-03-25 18:22 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-03-25 18:21 [2.6 patch] sound/oss/gus_wave.c: fix off by one errors Adrian Bunk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox