From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Pavel Machek <pavel@ucw.cz>
Cc: Andrew Morton <akpm@zip.com.au>,
kernel list <linux-kernel@vger.kernel.org>,
Greg KH <greg@kroah.com>,
Nigel Cunningham <ncunningham@linuxmail.org>
Subject: Re: Remaining u32 vs. pm_message_t fixes
Date: Fri, 25 Mar 2005 20:29:55 +0000 [thread overview]
Message-ID: <20050325202955.B12715@flint.arm.linux.org.uk> (raw)
In-Reply-To: <20050325102452.GA1352@elf.ucw.cz>; from pavel@ucw.cz on Fri, Mar 25, 2005 at 11:24:52AM +0100
On Fri, Mar 25, 2005 at 11:24:52AM +0100, Pavel Machek wrote:
> This fixes three remaining places where we put u32 (or worse
> suspend_state_t) into pm_message_t-sized box. As a bonus, PCI_D0 is
> used instead of constant 0. Please apply,
I suspect there's more than that still remaining. Have you tried
$ grep suspend include/asm-arm -r
?
Also, what about include/linux/device.h's struct device_driver, for
platform device drivers ?
I think there's a significant amount of work still to be done with
the u32 -> pm_message_t conversion before you can even think about
changing pm_message_t to a struct.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core
prev parent reply other threads:[~2005-03-25 20:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-25 10:24 Remaining u32 vs. pm_message_t fixes Pavel Machek
2005-03-25 20:29 ` Russell King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050325202955.B12715@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=akpm@zip.com.au \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ncunningham@linuxmail.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox