From: Willy Tarreau <willy@w.ods.org>
To: Marcelo Tosatti <marcelo.tosatti@cyclades.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Linux 2.4.30-rc2
Date: Sat, 26 Mar 2005 11:50:51 +0100 [thread overview]
Message-ID: <20050326105051.GL30052@alpha.home.local> (raw)
In-Reply-To: <20050326004631.GC17637@logos.cnet>
Marcelo,
just in case you release an -rc3, would you please include this typo fix
from Jurgen Quade. I have it in my tree since 2.4.23, it's a pure copy-paste
typo which causes the driver either to print an incomplete message or a
seconde unexpected one. BTW, it's fixed in 2.6.
Thanks,
Willy
--- ./drivers/block/floppy.old.c 2003-12-22 11:42:42.000000000 +0100
+++ ./drivers/block/floppy.c 2003-12-22 11:44:00.000000000 +0100
@@ -2563,7 +2563,7 @@
current_count_sectors);
if (CT(COMMAND) == FD_READ)
printk("read\n");
- if (CT(COMMAND) == FD_READ)
+ if (CT(COMMAND) == FD_WRITE)
printk("write\n");
break;
}
@@ -2894,7 +2894,7 @@
current_count_sectors);
if (CT(COMMAND) == FD_READ)
printk("read\n");
- if (CT(COMMAND) == FD_READ)
+ if (CT(COMMAND) == FD_WRITE)
printk("write\n");
return 0;
}
next prev parent reply other threads:[~2005-03-26 10:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-26 0:46 Linux 2.4.30-rc2 Marcelo Tosatti
2005-03-26 10:42 ` Willy Tarreau
2005-03-26 10:50 ` Willy Tarreau [this message]
2005-03-26 10:59 ` Willy Tarreau
2005-03-26 21:41 ` David S. Miller
2005-03-26 11:22 ` Willy Tarreau
2005-03-26 11:44 ` Arjan van de Ven
2005-03-26 12:27 ` Willy Tarreau
2005-03-26 16:07 ` Marcelo Tosatti
2005-03-26 11:34 ` Willy Tarreau
2005-03-26 11:46 ` Arjan van de Ven
2005-03-26 12:29 ` Willy Tarreau
2005-03-27 17:50 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050326105051.GL30052@alpha.home.local \
--to=willy@w.ods.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.tosatti@cyclades.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox