Re: Linux 2.4.30-rc2

[Willy Tarreau <willy@w.ods.org>]

On Sat, Mar 26, 2005 at 12:44:53PM +0100, Arjan van de Ven wrote:
> On Sat, 2005-03-26 at 12:22 +0100, Willy Tarreau wrote:
> > Marcelo,
> > 
> > here's a patch from Dave Jones, which is already in 2.6 and which I've
> > used in my local tree for 6 months now. It removes a useless NULL check
> > in zlib_inflateInit2_(), since 'z' is already dereferenced one line
> > before the test. Can in go in 2.4.30 please ?
> 
> I don't see how such a cleanup-only patch would be a candidate for 2.4
> at all, let alone to go into a -rc3 or a 2.4.30 final at this stage...
> 
> Can you explain why this one is so important that it has to go in so
> late?

On the contrary, it's just because it's not important at all that I
thought it could go in, the same way as other parts of unused code
got removed in rc2 (eg: jfs aops). As to the fact that it's late,
well, I would have prefered sending it sooner, but I simply don't
decide when I have spare time for this.

I have no problem at all with all these patches not merged, I simply
think that it makes maintainers' work easier to support homogeneous
code across versions with the least possible dead code, especially
when it comes to simple patches like this one. If you think it's better
to keep unused code because it makes debugging funnier, OK, that's fine.
Anyway, I'm just proposing, maintainers decide.

Willy