From: Marcelo Tosatti <marcelo.tosatti@cyclades.com>
To: Andreas Arens <andras@t-online.de>
Cc: herbert@gondor.apana.org.au, linux-kernel@vger.kernel.org
Subject: Re: Linux 2.4.30-rc2 - fix for CAN-2005-0794: Potential DOS in load_elf_library
Date: Sat, 26 Mar 2005 12:39:06 -0300 [thread overview]
Message-ID: <20050326153906.GA19501@logos.cnet> (raw)
In-Reply-To: <200503261314.01633.andras@t-online.de>
On Sat, Mar 26, 2005 at 01:14:01PM +0100, Andreas Arens wrote:
> Hi Marcelo, Herbert,
>
> I'm just reading the patch so don't know of any hidden side-effects which
> might cure it, but this clearly looks like a possibly deadlocking typo in
> fs/binfmt_elf.c to me:
> >
> >- while (elf_phdata->p_type != PT_LOAD) elf_phdata++;
> >+ while (elf_phdata->p_type != PT_LOAD)
> >+ eppnt++;
>
> Shouldn't this be:
>
> - while (elf_phdata->p_type != PT_LOAD) elf_phdata++;
> + while (eppnt->p_type != PT_LOAD)
> + eppnt++;
Doh.
Yes, it is. I change it accordingly, will release another -rc :(
parent reply other threads:[~2005-03-26 20:59 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <200503261314.01633.andras@t-online.de>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050326153906.GA19501@logos.cnet \
--to=marcelo.tosatti@cyclades.com \
--cc=andras@t-online.de \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox