* Re: Linux 2.4.30-rc2 - fix for CAN-2005-0794: Potential DOS in load_elf_library
[not found] <200503261314.01633.andras@t-online.de>
@ 2005-03-26 15:39 ` Marcelo Tosatti
0 siblings, 0 replies; only message in thread
From: Marcelo Tosatti @ 2005-03-26 15:39 UTC (permalink / raw)
To: Andreas Arens; +Cc: herbert, linux-kernel
On Sat, Mar 26, 2005 at 01:14:01PM +0100, Andreas Arens wrote:
> Hi Marcelo, Herbert,
>
> I'm just reading the patch so don't know of any hidden side-effects which
> might cure it, but this clearly looks like a possibly deadlocking typo in
> fs/binfmt_elf.c to me:
> >
> >- while (elf_phdata->p_type != PT_LOAD) elf_phdata++;
> >+ while (elf_phdata->p_type != PT_LOAD)
> >+ eppnt++;
>
> Shouldn't this be:
>
> - while (elf_phdata->p_type != PT_LOAD) elf_phdata++;
> + while (eppnt->p_type != PT_LOAD)
> + eppnt++;
Doh.
Yes, it is. I change it accordingly, will release another -rc :(
^ permalink raw reply [flat|nested] only message in thread