Re: x86-64 preemption fix from IRQ and BKL in 2.6.12-rc1-mm2

Andi Kleen
2005-03-28T15:26:48Z

On Sun, Mar 27, 2005 at 08:05:13PM +0200, Christophe Saout wrote:
> Am Sonntag, den 27.03.2005, 19:26 +0200 schrieb Andi Kleen:
>
> > > preempt_schedule_irq is not an i386 specific function and seems to take
> > > special care of BKL preemption and since reiserfs does use the BKL to do
> > > certain things I think this actually might be the problem...?
> >
> > Hmm, preempt_schedule_irq is not in mainline as far as I can see.
> > My patches are always for mainline; i dont do a special
> > patch kit for -mm*
>
> PREEMPT_BKL has been in mainline since 2.6.11-rc1, preempt_schedule_irq
> made it in 2.6.11-rc3. Please look here:
> http://linux.bkbits.net:8080/linux-2.6/search/?expr=preempt_schedule_irq&search=ChangeSet+comments

Hmm, true. I must have missed it with the last merge.

Looking at the changeset your simple patch is probably ok.

>
> Now that I looked into it I think that it's obviously the correct
> solution.

Agreed.

-Andi