From: Adrian Bunk <bunk@stusta.de>
To: tom.l.nguyen@intel.com
Cc: gregkh@suse.de, linux-kernel@vger.kernel.org,
linux-pci@atrey.karlin.mff.cuni.cz
Subject: [2.6 patch] drivers/pci/msi.c: fix a check after use
Date: Sun, 27 Mar 2005 23:15:24 +0200 [thread overview]
Message-ID: <20050327211524.GE4285@stusta.de> (raw)
This patch fixes a check after use found by the Coverity checker.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.12-rc1-mm1-full/drivers/pci/msi.c.old 2005-03-23 04:46:30.000000000 +0100
+++ linux-2.6.12-rc1-mm1-full/drivers/pci/msi.c 2005-03-23 04:47:03.000000000 +0100
@@ -703,12 +703,14 @@
**/
int pci_enable_msi(struct pci_dev* dev)
{
- int pos, temp = dev->irq, status = -EINVAL;
+ int pos, temp, status = -EINVAL;
u16 control;
if (!pci_msi_enable || !dev)
return status;
+ temp = dev->irq;
+
if ((status = msi_init()) < 0)
return status;
next reply other threads:[~2005-03-27 21:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-27 21:15 Adrian Bunk [this message]
2005-03-28 23:21 ` [2.6 patch] drivers/pci/msi.c: fix a check after use Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050327211524.GE4285@stusta.de \
--to=bunk@stusta.de \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=tom.l.nguyen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox