Re: [2.6 patch] sound/oss/rme96xx.c: fix two check after use

Christoph Hellwig
2005-04-13T14:58:59Z

On Wed, Apr 13, 2005 at 12:40:38PM +0200, Bodo Eggert <harvested.in.lkml@posting.7eggert.dyndns.org> wrote:
> If there are checks, they should be there for a purpose,

emphasis here is on _should_

> and any sane reader will asume these checks to be nescensary.

That's a bad assumptions when you're deadling with drivers or software of
similar quality.

> If they are dead code, you
> can say that, but please don't flame Adrian for fixing obviously buggy code
> in a way that is sane and at least more correct than the original without
> using several days of his lifetime to analyze the whole driver. Instead, you
> could provide the correct fix.

The correct fix is to remove the check. And no, we don't have a rule that
someone must provide something better when trying to critize it.