* [2.6 patch] drivers/usb/media/usbvideo.c: fix a check after use
@ 2005-03-27 20:48 Adrian Bunk
2005-03-27 22:02 ` Jean Delvare
2005-03-28 20:44 ` Greg KH
0 siblings, 2 replies; 3+ messages in thread
From: Adrian Bunk @ 2005-03-27 20:48 UTC (permalink / raw)
To: gregkh; +Cc: linux-usb-devel, linux-kernel
This patch fixes a check after use found by the Coverity checker.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.12-rc1-mm1-full/drivers/usb/media/usbvideo.c.old 2005-03-23 04:59:11.000000000 +0100
+++ linux-2.6.12-rc1-mm1-full/drivers/usb/media/usbvideo.c 2005-03-23 04:59:46.000000000 +0100
@@ -1814,12 +1814,12 @@
{
int i, j;
- if (uvd->debug > 1)
- info("%s($%p)", __FUNCTION__, uvd);
-
if ((uvd == NULL) || (!uvd->streaming) || (uvd->dev == NULL))
return;
+ if (uvd->debug > 1)
+ info("%s($%p)", __FUNCTION__, uvd);
+
/* Unschedule all of the iso td's */
for (i=0; i < USBVIDEO_NUMSBUF; i++) {
usb_kill_urb(uvd->sbuf[i].urb);
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [2.6 patch] drivers/usb/media/usbvideo.c: fix a check after use
2005-03-27 20:48 [2.6 patch] drivers/usb/media/usbvideo.c: fix a check after use Adrian Bunk
@ 2005-03-27 22:02 ` Jean Delvare
2005-03-28 20:44 ` Greg KH
1 sibling, 0 replies; 3+ messages in thread
From: Jean Delvare @ 2005-03-27 22:02 UTC (permalink / raw)
To: Adrian Bunk; +Cc: gregkh, linux-usb-devel, linux-kernel
Hi Adrian,
> This patch fixes a check after use found by the Coverity checker.
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
>
> --- linux-2.6.12-rc1-mm1-full/drivers/usb/media/usbvideo.c.old 2005-03-23 04:59:11.000000000 +0100
> +++ linux-2.6.12-rc1-mm1-full/drivers/usb/media/usbvideo.c 2005-03-23 04:59:46.000000000 +0100
> @@ -1814,12 +1814,12 @@
> {
> int i, j;
>
> - if (uvd->debug > 1)
> - info("%s($%p)", __FUNCTION__, uvd);
> -
> if ((uvd == NULL) || (!uvd->streaming) || (uvd->dev == NULL))
> return;
>
> + if (uvd->debug > 1)
> + info("%s($%p)", __FUNCTION__, uvd);
> +
Note that you slightly change the debug trace when doing this. For
example, the case where udv != NULL and !udv->streaming would display
the debug line before your patch, and no more after.
Now I don't know whether that change is a problem or not in this
particular case, as I am not the one who would debug this driver if
there were a problem with it, but this is something to pay attention to
in such cases.
Thanks,
--
Jean Delvare
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [2.6 patch] drivers/usb/media/usbvideo.c: fix a check after use
2005-03-27 20:48 [2.6 patch] drivers/usb/media/usbvideo.c: fix a check after use Adrian Bunk
2005-03-27 22:02 ` Jean Delvare
@ 2005-03-28 20:44 ` Greg KH
1 sibling, 0 replies; 3+ messages in thread
From: Greg KH @ 2005-03-28 20:44 UTC (permalink / raw)
To: Adrian Bunk; +Cc: gregkh, linux-usb-devel, linux-kernel
On Sun, Mar 27, 2005 at 10:48:52PM +0200, Adrian Bunk wrote:
> This patch fixes a check after use found by the Coverity checker.
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
Applied, thanks.
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2005-03-28 20:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-03-27 20:48 [2.6 patch] drivers/usb/media/usbvideo.c: fix a check after use Adrian Bunk
2005-03-27 22:02 ` Jean Delvare
2005-03-28 20:44 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox