From: Sam Ravnborg <sam@ravnborg.org>
To: jayalk@intworks.biz
Cc: hpa@zytor.com, linux-kernel@vger.kernel.org, davej@codemonkey.org.uk
Subject: Re: [RFC 2.6.11.2 1/1] Add reboot fixup for gx1/cs5530a
Date: Mon, 28 Mar 2005 23:17:07 +0200 [thread overview]
Message-ID: <20050328211707.GA8240@mars.ravnborg.org> (raw)
In-Reply-To: <200503281415.j2SEFwg4014119@intworks.biz>
Small comments below.
>
> +#ifdef CONFIG_X86_REBOOTFIXUPS
> +extern void mach_reboot_fixups(void);
> +#endif
Move this to header file.
> +#ifdef CONFIG_X86_REBOOTFIXUPS
> + mach_reboot_fixups();
> +#endif
And hide this ifdef in same hederfile.
#ifndef CONFIG_X86_REBOOTFIXUPS
#define mach_reboot_fixups do {} while (0);
#endif
Sam
next prev parent reply other threads:[~2005-03-28 21:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-28 14:15 [RFC 2.6.11.2 1/1] Add reboot fixup for gx1/cs5530a jayalk
2005-03-28 14:36 ` H. Peter Anvin
2005-03-28 14:38 ` H. Peter Anvin
2005-03-28 17:27 ` Jesper Juhl
2005-03-28 21:17 ` Sam Ravnborg [this message]
2005-03-28 21:17 ` H. Peter Anvin
2005-03-28 21:43 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050328211707.GA8240@mars.ravnborg.org \
--to=sam@ravnborg.org \
--cc=davej@codemonkey.org.uk \
--cc=hpa@zytor.com \
--cc=jayalk@intworks.biz \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox