Re: [patch] use cheaper elv_queue_empty when unplug a device

Nick Piggin
2005-03-29T09:22:31Z

[-- Attachment #1: Type: text/plain, Size: 299 bytes --]

Nick Piggin wrote:

> I haven't used a big disk array (or tried any simulation), but I'll
> attach the patch if you're looking into that area.
>

Oh, and this one removes a memory barrier. I think we (Jens and I)
agreed this is valid. Whether or not you'll notice a difference is
another story ;)

[-- Attachment #2: blk-no-mb.patch --]
[-- Type: text/plain, Size: 1192 bytes --]

This memory barrier is not needed because the waitqueue will only get
waiters on it in the following situations:

rq->count has exceeded the threshold - however all manipulations of ->count
are performed under the runqueue lock, and so we will correctly pick up any
waiter.

Memory allocation for the request fails. In this case, there is no additional
help provided by the memory barrier. We are guaranteed to eventually wake
up waiters because the request allocation mempool guarantees that if the mem
allocation for a request fails, there must be some requests in flight. They
will wake up waiters when they are retired.

---

linux-2.6-npiggin/drivers/block/ll_rw_blk.c | 1 -
1 files changed, 1 deletion(-)

diff -puN drivers/block/ll_rw_blk.c~blk-no-mb drivers/block/ll_rw_blk.c
--- linux-2.6/drivers/block/ll_rw_blk.c~blk-no-mb 2005-03-29 18:58:19.000000000 +1000
+++ linux-2.6-npiggin/drivers/block/ll_rw_blk.c 2005-03-29 19:20:10.000000000 +1000
@@ -1828,7 +1828,6 @@ static void __freed_request(request_queu
clear_queue_congested(q, rw);

if (rl->count[rw] + 1 <= q->nr_requests) {
- smp_mb();
if (waitqueue_active(&rl->wait[rw]))
wake_up(&rl->wait[rw]);

_