From: Jan Harkes <jaharkes@cs.cmu.edu>
To: lkml <linux-kernel@vger.kernel.org>,
"viro@parcelfarce.linux.theplanet.co.uk"
<viro@parcelfarce.linux.theplanet.co.uk>
Subject: Re: [PATCH] Set MS_ACTIVE in isofs_fill_super()
Date: Wed, 30 Mar 2005 18:18:40 -0500 [thread overview]
Message-ID: <20050330231840.GA6773@delft.aura.cs.cmu.edu> (raw)
In-Reply-To: <1112221619.9858.89.camel@russw.beaverton.ibm.com>
On Wed, Mar 30, 2005 at 02:26:59PM -0800, Russ Weight wrote:
> isofs_fill_super() is called by get_sb_bdev(), which is in the generic
> filesystem code. get_sb_bdev() receives a pointer as a parameter when it
> is called from isofs_get_sb(). To make a change in get_sb_bdev() would
> be to affect many (all?) filesystems. This may be the right thing to do
> - although it seems a little heavy-weight since the failure hasn't been
> reported in other filesystems.
It probably hasn't been reported in other filesystems because they only
use iput() in the error path if they can't get the dentry for the root
inode, which is probably a fairly rare situation. From what I can see
only isofs seems to intentionally drop the inode to grab another one.
Jan
prev parent reply other threads:[~2005-03-30 23:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-30 20:09 [PATCH] Set MS_ACTIVE in isofs_fill_super() Russ Weight
2005-03-30 20:39 ` Andrew Morton
2005-03-30 22:20 ` Jan Harkes
2005-04-01 15:14 ` Jan Kara
2005-03-30 22:26 ` Russ Weight
2005-03-30 23:18 ` Jan Harkes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050330231840.GA6773@delft.aura.cs.cmu.edu \
--to=jaharkes@cs.cmu.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@parcelfarce.linux.theplanet.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox