From: Andrew Morton <akpm@osdl.org>
To: Guillaume Thouvenin <guillaume.thouvenin@bull.net>
Cc: greg@kroah.com, linux-kernel@vger.kernel.org,
johnpol@2ka.mipt.ru, jlan@engr.sgi.com, efocht@hpce.nec.com,
linuxram@us.ibm.com, gh@us.ibm.com,
elsa-devel@lists.sourceforge.net, aquynh@gmail.com,
dean-list-linux-kernel@arctic.org, pj@sgi.com
Subject: Re: [patch 2.6.12-rc1-mm4] fork_connector: add a fork connector
Date: Thu, 31 Mar 2005 14:53:33 -0800 [thread overview]
Message-ID: <20050331145333.2012bf07.akpm@osdl.org> (raw)
In-Reply-To: <1112277542.20919.215.camel@frecb000711.frec.bull.fr>
Guillaume Thouvenin <guillaume.thouvenin@bull.net> wrote:
>
> This patch adds a fork connector in the do_fork() routine.
>
> +config FORK_CONNECTOR
> + bool "Enable fork connector"
> + depends on CONNECTOR=y
This kind of defeats connector's ability to be built as a module. Doing
select CONNECTOR
may be better here.
> +static void cn_fork_callback(void *data)
> +{
> + struct cn_msg *msg = (struct cn_msg *)data;
The cast is unnecessary.
>
> extern int cn_already_initialized;
> +extern int cn_fork_enable;
> +extern struct cb_id cb_fork_id;
Should these declarations be inside CONFIG_FORK_CONNECTOR?
> +
> +static DEFINE_PER_CPU(unsigned long, fork_counts);
> +
This will cause fork_counts to be defined in each compilation unit which
includes this header file. You should use DEFINE_PER_CPU in .c and
DECLARE_PER_CPU in .h.
next prev parent reply other threads:[~2005-03-31 22:54 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-31 13:59 [patch 2.6.12-rc1-mm4] fork_connector: add a fork connector Guillaume Thouvenin
2005-03-31 22:44 ` Andrew Morton
2005-04-01 0:10 ` Jay Lan
2005-04-01 7:52 ` Evgeniy Polyakov
2005-04-07 22:40 ` Jay Lan
2005-04-07 22:47 ` Jay Lan
2005-04-08 10:24 ` Evgeniy Polyakov
2005-04-08 10:52 ` Evgeniy Polyakov
2005-04-08 20:27 ` Jay Lan
2005-04-08 22:08 ` Jay Lan
2005-04-08 22:18 ` Evgeniy Polyakov
2005-04-09 3:31 ` Jay Lan
2005-04-09 6:29 ` Evgeniy Polyakov
2005-04-11 5:43 ` Jay Lan
2005-04-11 6:44 ` Evgeniy Polyakov
2005-04-11 6:51 ` Andrew Morton
2005-04-11 7:31 ` Evgeniy Polyakov
2005-03-31 22:53 ` Andrew Morton [this message]
2005-04-01 10:56 ` Guillaume Thouvenin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050331145333.2012bf07.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=aquynh@gmail.com \
--cc=dean-list-linux-kernel@arctic.org \
--cc=efocht@hpce.nec.com \
--cc=elsa-devel@lists.sourceforge.net \
--cc=gh@us.ibm.com \
--cc=greg@kroah.com \
--cc=guillaume.thouvenin@bull.net \
--cc=jlan@engr.sgi.com \
--cc=johnpol@2ka.mipt.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxram@us.ibm.com \
--cc=pj@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox