public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
Cc: linux-kernel@vger.kernel.org
Subject: connector.h
Date: Thu, 31 Mar 2005 17:31:01 -0800	[thread overview]
Message-ID: <20050331173101.769f5c67.akpm@osdl.org> (raw)


> 
> struct cb_id
> {
> 	__u32			idx;
> 	__u32			val;
> };

It is vital that all data structures be skilfully commented - they are the
key to understanding the code.  Why the struct exists, which actor passes
it to which other actor(s), whether the data structure is communicated with
userspace, what other data structures it is aggregated with or linked to,
locking rules, etc.

> struct cn_msg
> {

Please do

	struct cn_msg {

> 
> #define CN_CBQ_NAMELEN		32

Commentary?



             reply	other threads:[~2005-04-01  1:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-04-01  1:31 Andrew Morton [this message]
2005-04-01  7:09 ` connector.h Evgeniy Polyakov
2005-04-01  7:44   ` connector.h Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050331173101.769f5c67.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=johnpol@2ka.mipt.ru \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox