From: Tommy Reynolds <Tommy.Reynolds@MegaCoder.com>
To: linux-kernel@vger.kernel.org
Subject: Re: connector.c
Date: Thu, 31 Mar 2005 20:41:35 -0600 [thread overview]
Message-ID: <20050331204135.30270c78.Tommy.Reynolds@MegaCoder.com> (raw)
In-Reply-To: <20050331173026.3de81a05.akpm@osdl.org>
[-- Attachment #1: Type: text/plain, Size: 445 bytes --]
Uttered Andrew Morton <akpm@osdl.org>, spake thus:
> > if (uskb) {
> > netlink_unicast(dev->nls, uskb, 0, 0);
> > }
>
> Unneeded {}
Speaking strictly as a language lawyer, they are not needed.
However, for maintainability (and best practices) they are essential.
They make the scope of the test explicit and ensure that a one-line-
change really doesn't affect more lines that needed. Think context
diffs here.
Cheers!
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2005-04-01 2:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-01 1:30 connector.c Andrew Morton
2005-04-01 2:41 ` Tommy Reynolds [this message]
2005-04-01 14:29 ` connector.c Matthias Urlichs
2005-04-01 17:36 ` connector.c Paul Jackson
2005-04-01 7:07 ` connector.c Evgeniy Polyakov
2005-04-01 7:42 ` connector.c Andrew Morton
2005-04-01 8:03 ` connector.c Evgeniy Polyakov
2005-04-01 8:02 ` connector.c Andrew Morton
2005-04-01 8:28 ` connector.c Evgeniy Polyakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050331204135.30270c78.Tommy.Reynolds@MegaCoder.com \
--to=tommy.reynolds@megacoder.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox