From: Benjamin LaHaise <bcrl@kvack.org>
To: Adrian Bunk <bunk@stusta.de>
Cc: linux-ns83820@kvack.org, jgarzik@pobox.com,
linux-net@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC: 2.6 patch] drivers/net/ns83820.c: remove unused code
Date: Fri, 1 Apr 2005 15:55:07 -0500 [thread overview]
Message-ID: <20050401205507.GF27961@kvack.org> (raw)
In-Reply-To: <20050322215717.GO1948@stusta.de>
applied
On Tue, Mar 22, 2005 at 10:57:17PM +0100, Adrian Bunk wrote:
> The Coveity checker found that residue is always 0.
>
> Is this patch correct or should residue have been used?
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
>
> --- linux-2.6.12-rc1-mm1-full/drivers/net/ns83820.c.old 2005-03-22 21:32:15.000000000 +0100
> +++ linux-2.6.12-rc1-mm1-full/drivers/net/ns83820.c 2005-03-22 21:33:16.000000000 +0100
> @@ -1189,7 +1189,6 @@
>
> for (;;) {
> volatile u32 *desc = dev->tx_descs + (free_idx * DESC_SIZE);
> - u32 residue = 0;
>
> dprintk("frag[%3u]: %4u @ 0x%08Lx\n", free_idx, len,
> (unsigned long long)buf);
> @@ -1199,17 +1198,11 @@
> desc_addr_set(desc + DESC_BUFPTR, buf);
> desc[DESC_EXTSTS] = cpu_to_le32(extsts);
>
> - cmdsts = ((nr_frags|residue) ? CMDSTS_MORE : do_intr ? CMDSTS_INTR : 0);
> + cmdsts = ((nr_frags) ? CMDSTS_MORE : do_intr ? CMDSTS_INTR : 0);
> cmdsts |= (desc == first_desc) ? 0 : CMDSTS_OWN;
> cmdsts |= len;
> desc[DESC_CMDSTS] = cpu_to_le32(cmdsts);
>
> - if (residue) {
> - buf += len;
> - len = residue;
> - continue;
> - }
> -
> if (!nr_frags)
> break;
>
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-ns83820' in
> the body to majordomo@kvack.org.
--
"Time is what keeps everything from happening all at once." -- John Wheeler
prev parent reply other threads:[~2005-04-01 21:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-22 21:57 [RFC: 2.6 patch] drivers/net/ns83820.c: remove unused code Adrian Bunk
2005-04-01 20:55 ` Benjamin LaHaise [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050401205507.GF27961@kvack.org \
--to=bcrl@kvack.org \
--cc=bunk@stusta.de \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-net@vger.kernel.org \
--cc=linux-ns83820@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox